Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 573293004: Fix issue 17514770 (https://b2.corp.google.com/issues/17514770) (Closed)

Created:
6 years, 3 months ago by siva
Modified:
6 years, 3 months ago
Reviewers:
hausner, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix issue 20983 (https://code.google.com/p/dart/issues/detail?id=20983) The check for load error on completion of async load was very inefficient. Added a Hash set to ensure we don't repeatedly traverse through a library when trying to establish transitive load errors. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=40422

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Total comments: 4

Patch Set 8 : #

Total comments: 8

Patch Set 9 : #

Patch Set 10 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+607 lines, -10 lines) Patch
M runtime/vm/object.h View 1 2 3 4 5 6 7 8 9 2 chunks +9 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 4 5 6 7 8 9 2 chunks +45 lines, -9 lines 0 comments Download
M runtime/vm/object_store.h View 1 2 3 4 5 6 7 8 9 2 chunks +12 lines, -1 line 0 comments Download
M runtime/vm/object_store.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +2 lines, -0 lines 0 comments Download
A tests/language/issue_1751477.dart View 1 chunk +34 lines, -0 lines 0 comments Download
A tests/language/issue_1751477_lib1.dart View 1 chunk +28 lines, -0 lines 0 comments Download
A tests/language/issue_1751477_lib11.dart View 1 chunk +28 lines, -0 lines 0 comments Download
A tests/language/issue_1751477_lib2.dart View 1 chunk +28 lines, -0 lines 0 comments Download
A tests/language/issue_1751477_lib21.dart View 1 chunk +28 lines, -0 lines 0 comments Download
A tests/language/issue_1751477_lib3.dart View 1 chunk +28 lines, -0 lines 0 comments Download
A tests/language/issue_1751477_lib31.dart View 1 chunk +28 lines, -0 lines 0 comments Download
A tests/language/issue_1751477_lib4.dart View 1 chunk +28 lines, -0 lines 0 comments Download
A tests/language/issue_1751477_lib41.dart View 1 chunk +28 lines, -0 lines 0 comments Download
A tests/language/issue_1751477_lib5.dart View 1 chunk +28 lines, -0 lines 0 comments Download
A tests/language/issue_1751477_lib51.dart View 1 chunk +28 lines, -0 lines 0 comments Download
A tests/language/issue_1751477_lib6.dart View 1 chunk +28 lines, -0 lines 0 comments Download
A tests/language/issue_1751477_lib61.dart View 1 chunk +28 lines, -0 lines 0 comments Download
A tests/language/issue_1751477_lib7.dart View 1 chunk +28 lines, -0 lines 0 comments Download
A tests/language/issue_1751477_lib71.dart View 1 chunk +28 lines, -0 lines 0 comments Download
A tests/language/issue_1751477_lib8.dart View 1 chunk +28 lines, -0 lines 0 comments Download
A tests/language/issue_1751477_lib81.dart View 1 chunk +28 lines, -0 lines 0 comments Download
A tests/language/issue_1751477_lib9.dart View 1 chunk +28 lines, -0 lines 0 comments Download
A tests/language/issue_1751477_lib91.dart View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
siva
6 years, 3 months ago (2014-09-17 22:20:10 UTC) #2
siva
6 years, 3 months ago (2014-09-18 00:47:04 UTC) #3
siva
PTAL
6 years, 3 months ago (2014-09-18 00:56:33 UTC) #4
Ivan Posva
LGTM -ip https://codereview.chromium.org/573293004/diff/120001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/573293004/diff/120001/runtime/vm/object.cc#newcode9999 runtime/vm/object.cc:9999: LibraryLoadErrorSet set(HashTables::New<LibraryLoadErrorSet>(kNumLibs)); How about just calling set.Clear() ...
6 years, 3 months ago (2014-09-18 00:58:05 UTC) #5
siva
https://codereview.chromium.org/573293004/diff/120001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/573293004/diff/120001/runtime/vm/object.cc#newcode9999 runtime/vm/object.cc:9999: LibraryLoadErrorSet set(HashTables::New<LibraryLoadErrorSet>(kNumLibs)); On 2014/09/18 00:58:04, Ivan Posva wrote: > ...
6 years, 3 months ago (2014-09-18 01:07:37 UTC) #6
siva
6 years, 3 months ago (2014-09-18 02:01:37 UTC) #7
Message was sent while issue was closed. 
Committed patchset #10 (id:170001) manually as r40422 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698