Parse the repo's version file when running from the repo.

Parse the repo's version file when running from the repo.

R=nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40381

[Bob Nystrom, 2014-09-15 21:15:50]

rnystrom@google.com changed reviewers:
+ nweiz@google.com

[nweiz, 2014-09-15 23:12:26]

https://codereview.chromium.org/572053002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/sdk.dart (right):

https://codereview.chromium.org/572053002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/sdk.dart:42: if (runningFromSdk) {
Does this getter still return the right thing when running tests?

https://codereview.chromium.org/572053002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/sdk.dart:49: // This makes it possible to run pub
without having built the SDK first.
Does this mean that our tests now depend on being run from a prebuilt SDK?

https://codereview.chromium.org/572053002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/sdk.dart:67: // TODO(rnystrom): tools/utils.py
includes the svn commit here. Should we?
Probably? How painful is it to get?

[Bob Nystrom, 2014-09-15 23:41:10]

https://codereview.chromium.org/572053002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/sdk.dart (right):

https://codereview.chromium.org/572053002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/sdk.dart:42: if (runningFromSdk) {
On 2014/09/15 23:12:25, nweiz wrote:
> Does this getter still return the right thing when running tests?

The tests don't actually get this far. They set _PUB_TEST_SDK_VERSION. :)

https://codereview.chromium.org/572053002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/sdk.dart:49: // This makes it possible to run pub
without having built the SDK first.
On 2014/09/15 23:12:25, nweiz wrote:
> Does this mean that our tests now depend on being run from a prebuilt SDK?

Our tests would have previously required that if we weren't setting
_PUB_TEST_SDK_VERSION. This change means they no longer do.

https://codereview.chromium.org/572053002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/sdk.dart:67: // TODO(rnystrom): tools/utils.py
includes the svn commit here. Should we?
On 2014/09/15 23:12:26, nweiz wrote:
> Probably? How painful is it to get?

It's actually pretty hairy. 60 lines of Python that handles git, svn, git-svn,
and does a bunch of output parsing. I think we can get by with not having it. It
would only matter if there were version constraints that mentioned specific svn
commits, but we'd have much bigger problems if that was the case.

[nweiz, 2014-09-15 23:57:00]

lgtm

[Bob Nystrom, 2014-09-17 17:37:54]

Committed patchset #1 (id:1) manually as 40381 (presubmit successful).