only run the admin server if admin-port is specified

only run the admin server if admin-port is specified

BUG=
R=nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40293

[sethladd, 2014-09-12 21:08:38]

sethladd@google.com changed reviewers:
+ nweiz@google.com, rnystrom@google.com

[sethladd, 2014-09-12 21:14:42]

I manually tested with both --admin-port and no admin-port. Seemed to work (it
did not conflict with an existing port, like the current version does)

I tried running ./tools/test.py -m release pub and I got various:

| FINE: Initializing barback finished (3.2s).
  | ERR : Class 'ServeCommand' has no instance getter 'server'.
  |     | 
  |     | NoSuchMethodError: method not found: 'server'
  |     | Receiver: Instance of 'ServeCommand'
  |     | Arguments: []
  | FINE: Exception type: NoSuchMethodError
  | ERR :
/Users/sethladd/Code/Dart/dart/sdk/lib/_internal/pub_generated/lib/src/utils.dart
53     syncFuture
  |     |
/Users/sethladd/Code/Dart/dart/sdk/lib/_internal/pub_generated/lib/src/command.dart
113  PubCommand.run
  |     |
/Users/sethladd/Code/Dart/dart/sdk/lib/_internal/pub_generated/bin/pub.dart 133 
        invokeCommand.<fn>.break0.join0
  |     |
/Users/sethladd/Code/Dart/dart/sdk/lib/_internal/pub_generated/bin/pub.dart 143 
        invokeCommand.<fn>.break0
  |     |
/Users/sethladd/Code/Dart/dart/sdk/lib/_internal/pub_generated/bin/pub.dart 201 
        invokeCommand.<fn>.continue0
  |     |
/Users/sethladd/Code/Dart/dart/sdk/lib/_internal/pub_generated/bin/pub.dart 155 
        invokeCommand.<fn>.continue0.<fn>.join2.join3
  |     |
/Users/sethladd/Code/Dart/dart/sdk/lib/_internal/pub_generated/bin/pub.dart 161 
        invokeCommand.<fn>.continue0.<fn>.join2
  |     |
/Users/sethladd/Code/Dart/dart/sdk/lib/_internal/pub_generated/bin/pub.dart 197 
        invokeCommand.<fn>.continue0.<fn>
  |     | dart:isolate                                                          
                  _RawReceivePortImpl._handleMessage
  |     | ===== asynchronous gap ===========================
  |     | dart:async                                                            
          _Future.then
  |     |
/Users/sethladd/Code/Dart/dart/sdk/lib/_internal/pub_generated/bin/pub.dart 148 
invokeCommand.<fn>.continue0
  |     |
/Users/sethladd/Code/Dart/dart/sdk/lib/_internal/pub_generated/bin/pub.dart 204 
invokeCommand.<fn>
  |     | dart:isolate                                                          
          _RawReceivePortImpl._handleMessage
  |     | ===== asynchronous gap ===========================
  |     | dart:async                                                            
               scheduleMicrotask
  |     |
/Users/sethladd/Code/Dart/dart/sdk/lib/_internal/pub_generated/bin/pub.dart 112 
     invokeCommand
  |     |
/Users/sethladd/Code/Dart/dart/sdk/lib/_internal/pub_generated/bin/pub.dart 75  
     runPub.<fn>
  |     | dart:async                                                            
               Future.Future.sync
  |     |
/Users/sethladd/Code/Dart/dart/sdk/lib/_internal/pub_generated/lib/src/utils.dart
57  captureErrors.<fn>
  |     | package:stack_trace/src/chain.dart 93                                 
               Chain.capture
  |     |
/Users/sethladd/Code/Dart/dart/sdk/lib/_internal/pub_generated/lib/src/utils.dart
68  captureErrors
  |     |
/Users/sethladd/Code/Dart/dart/sdk/lib/_internal/pub_generated/bin/pub.dart 74  
     runPub
  |     |
/Users/sethladd/Code/Dart/dart/sdk/lib/_internal/pub_generated/bin/pub.dart 67  
     main.<fn>
  |     | dart:isolate                                                          
               _RawReceivePortImpl._handleMessage
  | ERR : This is an unexpected error. Please run
  |     | 
  |     |     pub --trace '--verbose' 'serve' '--port=0' '--force-poll'
'--log-admin-url'
  |     | 
  |     | and include the results in a bug report on http://dartbug.com/new.

00:16 +0 -4: Some tests failed.                                         
0 PASSED, 4 FAILED, 0 ERRORS



Not sure how to check if this is expected/should be ignored.

[nweiz, 2014-09-15 19:21:48]

https://codereview.chromium.org/571633002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/command/serve.dart (right):

https://codereview.chromium.org/571633002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/command/serve.dart:71:
commandParser.addFlag('log-admin-url', defaultsTo: false, hide: true);
We should make this option a no-op and always log the admin URL if --admin-port
is passed.

https://codereview.chromium.org/571633002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/command/serve.dart:107: }
This should only be run if adminPort is set.

[sethladd, 2014-09-16 00:08:34]

Thanks! Addressed comments.

https://codereview.chromium.org/571633002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/command/serve.dart (right):

https://codereview.chromium.org/571633002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/command/serve.dart:71:
commandParser.addFlag('log-admin-url', defaultsTo: false, hide: true);
Thanks. Done.

https://codereview.chromium.org/571633002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/command/serve.dart:107: }
Good call. Done.

[nweiz, 2014-09-16 00:16:32]

lgtm

https://codereview.chromium.org/571633002/diff/20001/sdk/lib/_internal/pub/li...
File sdk/lib/_internal/pub/lib/src/command/serve.dart (right):

https://codereview.chromium.org/571633002/diff/20001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/command/serve.dart:51: bool get logAdminUrl =>
commandOptions['log-admin-url'];
Remove this getter, since it's now unused.

https://codereview.chromium.org/571633002/diff/20001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/command/serve.dart:67: // TODO: Remove once editor
also removes this. This is now a NOOP.
Add your username to this TODO (or mine, if you prefer). Also, file a bug
against the editor and reference it here.

[sethladd, 2014-09-16 00:21:56]

Committed patchset #3 (id:40001) manually as 40293 (presubmit successful).