Issue 571523002: Issue 20894. Rename 'Class' when rename refactoring is activated on 'Class' in 'new Class.name()'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 571523002: Issue 20894. Rename 'Class' when rename refactoring is activated on 'Class' in 'new Class.name()'. (Closed)

Created:
6 years, 3 months ago by scheglov

Modified:
6 years, 3 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Issue 20894. Rename 'Class' when rename refactoring is activated on 'Class' in 'new Class.name()'. To do this we need to tweak the Java version of ElementLocator and regenarate the Dart version. R=brianwilkerson@google.com BUG= https://code.google.com/p/dart/issues/detail?id=20894 Committed: https://code.google.com/p/dart/source/detail?r=40208

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+131 lines, -58 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/visitor/ElementLocator.java	View	3 chunks	+0 lines, -21 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/ast/visitor/ElementLocatorTest.java	View	2 chunks	+8 lines, -4 lines	0 comments	Download
M	pkg/analysis_server/pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/test/edit/refactoring_test.dart	View	2 chunks	+26 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/generated/ast.dart	View	1 chunk	+0 lines, -19 lines	0 comments	Download
M	pkg/analyzer/pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/test/generated/all_the_rest.dart	View	1 chunk	+8 lines, -4 lines	0 comments	Download
M	pkg/analyzer/test/generated/engine_test.dart	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	pkg/analyzer/test/generated/resolver_test.dart	View	4 chunks	+80 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

scheglov

6 years, 3 months ago (2014-09-12 17:16:24 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 40208 (presubmit successful).