Issue 571133002: PageIterator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 571133002: PageIterator (Closed)

Created:
6 years, 3 months ago by koda

Modified:
6 years, 3 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Lazy walkability of old-space bump allocation block. Do not write a freelist-element header into remainder on every allocation. Add ExclusivePageIterator that locks and ensures walkability, and reduces code duplication. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=40505

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -54 lines)			Patch
M	runtime/vm/gc_sweeper.h	View		2 chunks	+1 line, -6 lines	0 comments	Download
M	runtime/vm/gc_sweeper.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/pages.h	View		4 chunks	+9 lines, -0 lines	0 comments	Download
M	runtime/vm/pages.cc	View	1 2 3	6 chunks	+63 lines, -47 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM -ip https://codereview.chromium.org/571133002/diff/60001/runtime/vm/pages.cc File runtime/vm/pages.cc (right): https://codereview.chromium.org/571133002/diff/60001/runtime/vm/pages.cc#newcode421 runtime/vm/pages.cc:421: bool done() const { return page_ == ...

6 years, 3 months ago (2014-09-19 17:11:54 UTC) #2

koda

https://codereview.chromium.org/571133002/diff/60001/runtime/vm/pages.cc File runtime/vm/pages.cc (right): https://codereview.chromium.org/571133002/diff/60001/runtime/vm/pages.cc#newcode421 runtime/vm/pages.cc:421: bool done() const { return page_ == NULL; } ...

6 years, 3 months ago (2014-09-19 17:25:00 UTC) #3

koda

6 years, 3 months ago (2014-09-19 17:25:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as r40505 (presubmit successful).

Expand Messages | Collapse Messages