Temporarily add a public modPow method to int interface.

Temporarily add a public modPow method to int interface.
Make Bigint modPow support non-bigint arguments.

R=srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40335

[regis, 2014-09-15 23:42:45]

regis@google.com changed reviewers:
+ srdjan@google.com

[regis, 2014-09-16 00:12:28]

On 2014/09/15 23:42:45, regis wrote:

I sent this a bit too hastily (let's blame it on the shuttle).
I need to check the types of e and m in int.modPow and foward to _Bigint.modPow
if one of them is of type _Bigint. And I suppose we should throw if they are not
int.

I'll update this cl tomorrow.

[regis, 2014-09-16 16:01:32]

On 2014/09/16 00:12:28, regis wrote:
> On 2014/09/15 23:42:45, regis wrote:
> 
> I sent this a bit too hastily (let's blame it on the shuttle).
> I need to check the types of e and m in int.modPow and foward to
_Bigint.modPow
> if one of them is of type _Bigint. And I suppose we should throw if they are
not
> int.
> 
> I'll update this cl tomorrow.

PTAL

[srdjan, 2014-09-16 18:08:36]

lgtm

https://codereview.chromium.org/570563004/diff/40001/runtime/lib/integers.dart
File runtime/lib/integers.dart (right):

https://codereview.chromium.org/570563004/diff/40001/runtime/lib/integers.dar...
runtime/lib/integers.dart:272: if (m is! int) throw new ArgumentError(m);
Maybe instead:
if ((e is! int) || (m is! int) {
  return pow(this, e) % m;
}

[regis, 2014-09-16 18:18:55]

https://codereview.chromium.org/570563004/diff/40001/runtime/lib/integers.dart
File runtime/lib/integers.dart (right):

https://codereview.chromium.org/570563004/diff/40001/runtime/lib/integers.dar...
runtime/lib/integers.dart:272: if (m is! int) throw new ArgumentError(m);
On 2014/09/16 18:08:36, srdjan wrote:
> Maybe instead:
> if ((e is! int) || (m is! int) {
>   return pow(this, e) % m;
> }

This can be done when we add modPow to dart:math. I'd rather not change the
argument types from int to num here and call math.pow from here.

[regis, 2014-09-16 18:19:16]

Committed patchset #3 (id:40001) manually as r40335 (presubmit successful).