Issue 570133003: Instead of special casing one-element interpolations, just generate a static call to _interpolateSi…

Issue 570133003: Instead of special casing one-element interpolations, just generate a static call to _interpolateSi… (Closed)

Created:
6 years, 3 months ago by Lasse Reichstein Nielsen

Modified:
6 years, 3 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org, srdjan

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Instead of special casing one-element interpolations, just generate a static call to _interpolateSingle directly in the IL. R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=40367 Committed: https://code.google.com/p/dart/source/detail?r=40369

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -37 lines)			Patch
M	runtime/vm/flow_graph_builder.cc	View	1 2	1 chunk	+27 lines, -6 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View		2 chunks	+2 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1	2 chunks	+1 line, -26 lines	0 comments	Download

Total messages: 8 (1 generated)

Lasse Reichstein Nielsen

Reduces the complexity of the previous version, and is 50% to 700% faster again.

6 years, 3 months ago (2014-09-16 12:04:59 UTC) #2

Lasse Reichstein Nielsen

The 700% is only the initial run, repeats of the same benchmark falls down to ...

6 years, 3 months ago (2014-09-16 12:13:03 UTC) #3

Lasse Reichstein Nielsen

Committed patchset #1 (id:1) manually as 40367 (presubmit successful).

6 years, 3 months ago (2014-09-17 07:38:38 UTC) #5

Florian Schneider

On 2014/09/17 08:55:19, Lasse Reichstein Nielsen wrote: > Fixed incorrect Handle type, PTAL. Oh yes, ...

6 years, 3 months ago (2014-09-17 09:14:11 UTC) #7

Lasse Reichstein Nielsen

6 years, 3 months ago (2014-09-17 09:32:15 UTC) #8

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as 40369 (presubmit successful).