Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 569313002: Skip compilation of signature classes. (Closed)

Created:
6 years, 3 months ago by siva
Modified:
6 years, 3 months ago
Reviewers:
regis, hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Skip compilation of signature classes. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=40273

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -6 lines) Patch
M runtime/vm/bootstrap.cc View 1 2 chunks +15 lines, -6 lines 0 comments Download
M runtime/vm/compiler.cc View 1 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
siva
6 years, 3 months ago (2014-09-15 17:51:05 UTC) #2
hausner
https://codereview.chromium.org/569313002/diff/1/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://codereview.chromium.org/569313002/diff/1/runtime/vm/compiler.cc#newcode163 runtime/vm/compiler.cc:163: LongJumpScope jump; DBC: since you depend on the Function ...
6 years, 3 months ago (2014-09-15 18:11:31 UTC) #4
regis
LGTM
6 years, 3 months ago (2014-09-15 19:33:39 UTC) #5
siva
https://codereview.chromium.org/569313002/diff/1/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://codereview.chromium.org/569313002/diff/1/runtime/vm/compiler.cc#newcode163 runtime/vm/compiler.cc:163: LongJumpScope jump; On 2014/09/15 18:11:31, hausner wrote: > DBC: ...
6 years, 3 months ago (2014-09-15 20:24:39 UTC) #6
siva
6 years, 3 months ago (2014-09-15 20:25:23 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as r40273 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698