Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 569173003: Fix datagram issue where available is not correctly updated upon receive. (Closed)

Created:
6 years, 3 months ago by Anders Johnsen
Modified:
6 years, 3 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva
Visibility:
Public.

Description

Fix datagram issue where available is not correctly updated upon receive. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=40235

Patch Set 1 #

Patch Set 2 : Fix CR #

Total comments: 2

Patch Set 3 : Comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -7 lines) Patch
M runtime/bin/socket_patch.dart View 1 2 1 chunk +5 lines, -7 lines 0 comments Download
A tests/standalone/io/raw_datagram_read_all_test.dart View 1 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Anders Johnsen
6 years, 3 months ago (2014-09-15 08:15:20 UTC) #2
Søren Gjesse
LGTM! https://codereview.chromium.org/569173003/diff/20001/runtime/bin/socket_patch.dart File runtime/bin/socket_patch.dart (right): https://codereview.chromium.org/569173003/diff/20001/runtime/bin/socket_patch.dart#newcode570 runtime/bin/socket_patch.dart:570: if (result != null) { Please add a ...
6 years, 3 months ago (2014-09-15 08:20:32 UTC) #3
Anders Johnsen
https://codereview.chromium.org/569173003/diff/20001/runtime/bin/socket_patch.dart File runtime/bin/socket_patch.dart (right): https://codereview.chromium.org/569173003/diff/20001/runtime/bin/socket_patch.dart#newcode570 runtime/bin/socket_patch.dart:570: if (result != null) { On 2014/09/15 08:20:32, Søren ...
6 years, 3 months ago (2014-09-15 08:21:37 UTC) #4
Anders Johnsen
Committed patchset #3 (id:40001) manually as 40235 (presubmit successful).
6 years, 3 months ago (2014-09-15 08:21:50 UTC) #5
zra
6 years, 3 months ago (2014-09-22 16:24:55 UTC) #6
Message was sent while issue was closed.
On 2014/09/15 08:21:50, Anders Johnsen wrote:
> Committed patchset #3 (id:40001) manually as 40235 (presubmit successful).

I'm afraid that this will lead to starvation. Is it possible to write a test for
that?

Otherwise, I think we should back out this change, and modify the documentation
to recommend draining the stream using the async method in our email discussion.

Powered by Google App Engine
This is Rietveld 408576698