Issue 568463002: fix auto-binding-dart example

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 568463002: fix auto-binding-dart example (Closed)

Created:
6 years, 3 months ago by jakemac

Modified:
6 years, 3 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

fix auto-binding-dart example BUG= http://dartbug.com/20900 R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=40157

Patch Set 2 : fix auto-binding-dart example so it works in built output #

Total comments: 1

Patch Set 3 : add note to example #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	pkg/polymer/lib/auto_binding.dart	View	1 2	2 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Siggi Cherem (dart-lang)

https://codereview.chromium.org/568463002/diff/20001/pkg/polymer/lib/auto_binding.dart File pkg/polymer/lib/auto_binding.dart (right): https://codereview.chromium.org/568463002/diff/20001/pkg/polymer/lib/auto_binding.dart#newcode33 pkg/polymer/lib/auto_binding.dart:33: * var template = document.querySelector('#my-template'); might be worth mentioning ...

6 years, 3 months ago (2014-09-11 15:44:22 UTC) #4

jakemac

6 years, 3 months ago (2014-09-11 16:07:10 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as 40157 (presubmit successful).