Issue 56773002: Issue 13241. Report StaticWarningCode.CONFLICTING_INSTANCE_METHOD_SETTER.

Issue 56773002: Issue 13241. Report StaticWarningCode.CONFLICTING_INSTANCE_METHOD_SETTER. (Closed)

Created:
7 years, 1 month ago by scheglov

Modified:
7 years, 1 month ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, lukeechurch_gmail.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 13241. Report StaticWarningCode.CONFLICTING_INSTANCE_METHOD_SETTER. https://code.google.com/p/dart/issues/detail?id=13241 R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=29787

Patch Set 2 : Use InheritanceManager #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -9 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticWarningCode.java	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java	View	1	2 chunks	+39 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java	View	1	1 chunk	+37 lines, -0 lines	0 comments	Download
M	tests/co19/co19-analyzer.status	View		3 chunks	+10 lines, -7 lines	0 comments	Download
M	tests/language/language_analyzer.status	View		2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/56773002/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java (right): https://codereview.chromium.org/56773002/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java#newcode2290 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java:2290: ExecutableElement setter = enclosingType.lookUpSetter(name, currentLibrary); Should this be ...

7 years, 1 month ago (2013-11-02 15:19:37 UTC) #2

scheglov

https://codereview.chromium.org/56773002/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java (right): https://codereview.chromium.org/56773002/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java#newcode2290 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java:2290: ExecutableElement setter = enclosingType.lookUpSetter(name, currentLibrary); On 2013/11/02 15:19:38, Brian ...

7 years, 1 month ago (2013-11-02 20:32:00 UTC) #3

scheglov

7 years, 1 month ago (2013-11-02 20:32:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r29787 (presubmit successful).

Expand Messages | Collapse Messages