Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 566433003: Use Relationship as a first key in the index store. (Closed)

Created:
6 years, 3 months ago by scheglov
Modified:
6 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use Relationship as a first key in the index store. This significantly speeds up computing type hierarchies. For example for List we don't have to read all the nodes (files) where it is used as a type annotation. We read node where it IS_EXTENDED_BY and IS_IMPLEMENTED_BY. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=40152

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -25 lines) Patch
M pkg/analysis_server/lib/src/services/index/store/split_store.dart View 10 chunks +45 lines, -25 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 3 months ago (2014-09-11 02:15:27 UTC) #1
Brian Wilkerson
LGTM > This significantly speeds up computing type hierarchies. Do you have any information about ...
6 years, 3 months ago (2014-09-11 14:42:22 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 40152 (presubmit successful).
6 years, 3 months ago (2014-09-11 15:40:55 UTC) #3
scheglov
6 years, 3 months ago (2014-09-11 15:44:03 UTC) #4
Message was sent while issue was closed.
On 2014/09/11 14:42:22, Brian Wilkerson wrote:
> LGTM
> 
> > This significantly speeds up computing type hierarchies.
> 
> Do you have any information about what it does for other queries?

It also significantly speeds up search for member references, because we
actually return all the references to all the member in the hierarchy.
So, for example when we search for String.endsWidth, we try to build String
hierarchy (only String) and it is the same index request as "Type Hierarchy"
does.
So, it is now also about 200 ms (with analyzer project only) vs. 2000+ ms
before.

Powered by Google App Engine
This is Rietveld 408576698