Issue 565673007: Resurrect tests from deleted bigint_operations_test.cc into new bigint_test.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 565673007: Resurrect tests from deleted bigint_operations_test.cc into new bigint_test.cc (Closed)

Created:
6 years, 3 months ago by regis

Modified:
6 years, 3 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Resurrect tests from deleted bigint_operations_test.cc into new bigint_test.cc and into existing big_integer_vm_test.dart. Fix a rounding error allocating digit array in Bigint::NewFromDecCString. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=40188

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2291 lines, -168 lines)			Patch
A	runtime/vm/bigint_test.cc	View	1 chunk	+656 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/vm_sources.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/corelib/big_integer_vm_test.dart	View	1 chunk	+1633 lines, -167 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

regis

6 years, 3 months ago (2014-09-11 22:34:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r40188 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages