Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 56553004: Reapply "Set runtime type on list and map literals." (Closed)

Created:
7 years, 1 month ago by karlklose
Modified:
7 years, 1 month ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 : #

Patch Set 2 : Fix missing type registration and a type error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 1 4 chunks +15 lines, -0 lines 0 comments Download
M sdk/lib/_internal/lib/async_patch.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-dart2js.status View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/corelib/corelib.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
karlklose
Patch 1 is the rebased original CL, patch 2 contains the fixes.
7 years, 1 month ago (2013-11-04 09:49:41 UTC) #1
Johnni Winther
lgtm
7 years, 1 month ago (2013-11-04 10:20:18 UTC) #2
karlklose
7 years, 1 month ago (2013-11-04 10:25:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r29798 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698