Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 56533002: Added even more documentation to Element. (Closed)

Created:
7 years, 1 month ago by Andrei Mouravski
Modified:
7 years, 1 month ago
Reviewers:
Kathy Walrath
CC:
reviews_dartlang.org, blois, Jennifer Messerly
Visibility:
Public.

Description

Added even more documentation to Element. Committed: https://code.google.com/p/dart/source/detail?r=29774

Patch Set 1 #

Patch Set 2 : Added regionoverset. #

Patch Set 3 : A few more things. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+341 lines, -3 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 10 chunks +125 lines, -1 line 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 4 chunks +75 lines, -1 line 0 comments Download
M tools/dom/docs/docs.json View 1 2 5 chunks +109 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 2 3 chunks +32 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Andrei Mouravski
Submitting TBR.
7 years, 1 month ago (2013-11-01 22:10:06 UTC) #1
Andrei Mouravski
Committed patchset #3 manually as r29774 (presubmit successful).
7 years, 1 month ago (2013-11-01 22:10:43 UTC) #2
Kathy Walrath
7 years, 1 month ago (2013-11-04 17:01:27 UTC) #3
Message was sent while issue was closed.
lgtm

In method descriptions, I think I'd use just "See also:" (no heading) instead of
##Other resources, but it's not a big deal.

Powered by Google App Engine
This is Rietveld 408576698