Issue 564413005: Issue 17389. Analyzer snapshot and server tweaks to use new ParameterElement.defaultValueCode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 564413005: Issue 17389. Analyzer snapshot and server tweaks to use new ParameterElement.defaultValueCode. (Closed)

Created:
6 years, 3 months ago by scheglov

Modified:
6 years, 3 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Issue 17389. Analyzer snapshot and server tweaks to use new ParameterElement.defaultValueCode. This also makes Analysis Server to return hovers with parameter default values. R=brianwilkerson@google.com BUG= https://code.google.com/p/dart/issues/detail?id=17389 Committed: https://code.google.com/p/dart/source/detail?r=40298

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -67 lines)			Patch
M	pkg/analysis_server/lib/src/services/correction/fix_internal.dart	View	5 chunks	+10 lines, -34 lines	0 comments	Download
M	pkg/analysis_server/pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/generated/element.dart	View	6 chunks	+19 lines, -28 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/element_handle.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/generated/resolver.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/test/generated/all_the_rest.dart	View	2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Brian Wilkerson

LGTM. If we haven't published since last Thursday we should hold off so that we ...

6 years, 3 months ago (2014-09-15 16:26:18 UTC) #2

scheglov

6 years, 3 months ago (2014-09-16 01:46:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 40298 (presubmit successful).