Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(968)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 564403002: Handle implicitly hidden exports. (Closed)

Created:
6 years, 3 months ago by Johnni Winther
Modified:
3 years, 9 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Handle implicitly hidden exports. BUG=http://dartbug.com/20935 R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=40310 Reopen due to revert. Infinite loop in co19/Language/14_Libraries_and_Scripts/1_Imports_A02_t22

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -70 lines) Patch
M sdk/lib/_internal/compiler/implementation/library_loader.dart View 1 2 chunks +110 lines, -58 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/warnings.dart View 2 chunks +31 lines, -0 lines 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +3 lines, -0 lines 0 comments Download
A + tests/language/regress_20935_bar.dart View 1 chunk +1 line, -3 lines 0 comments Download
A + tests/language/regress_20935_foo.dart View 1 chunk +2 lines, -3 lines 0 comments Download
A + tests/language/regress_20935_test.dart View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
6 years, 3 months ago (2014-09-15 09:06:04 UTC) #2
karlklose
LGTM. https://codereview.chromium.org/564403002/diff/1/sdk/lib/_internal/compiler/implementation/library_loader.dart File sdk/lib/_internal/compiler/implementation/library_loader.dart (right): https://codereview.chromium.org/564403002/diff/1/sdk/lib/_internal/compiler/implementation/library_loader.dart#newcode836 sdk/lib/_internal/compiler/implementation/library_loader.dart:836: if (!element.library.isPlatformLibrary) { Consider to extract boolean variables ...
6 years, 3 months ago (2014-09-15 09:34:31 UTC) #3
Johnni Winther
https://codereview.chromium.org/564403002/diff/1/sdk/lib/_internal/compiler/implementation/library_loader.dart File sdk/lib/_internal/compiler/implementation/library_loader.dart (right): https://codereview.chromium.org/564403002/diff/1/sdk/lib/_internal/compiler/implementation/library_loader.dart#newcode836 sdk/lib/_internal/compiler/implementation/library_loader.dart:836: if (!element.library.isPlatformLibrary) { On 2014/09/15 09:34:31, karlklose wrote: > ...
6 years, 3 months ago (2014-09-16 11:03:32 UTC) #4
Johnni Winther
6 years, 3 months ago (2014-09-16 11:14:40 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 40310 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698