Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 564373004: Add LibraryLoader.resetAsync. (Closed)

Created:
6 years, 3 months ago by ahe
Modified:
6 years, 3 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, kasperl, lukechurch
Visibility:
Public.

Description

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Restore code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -43 lines) Patch
M dart/pkg/dart2js_incremental/lib/caching_compiler.dart View 4 chunks +18 lines, -15 lines 0 comments Download
M dart/pkg/dart2js_incremental/lib/dart2js_incremental.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/compiler.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/library_loader.dart View 2 chunks +45 lines, -5 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/use_unused_api.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M dart/site/try/poi/poi.dart View 1 7 chunks +24 lines, -15 lines 0 comments Download
M dart/site/try/src/compiler_isolate.dart View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ahe
6 years, 3 months ago (2014-09-15 13:50:14 UTC) #3
Johnni Winther
lgtm https://codereview.chromium.org/564373004/diff/20001/dart/site/try/poi/poi.dart File dart/site/try/poi/poi.dart (right): https://codereview.chromium.org/564373004/diff/20001/dart/site/try/poi/poi.dart#newcode385 dart/site/try/poi/poi.dart:385: // newCompiler.enqueuerFilter = filter; Is this intentional?
6 years, 3 months ago (2014-09-16 09:34:50 UTC) #4
ahe
Thank you, Johnni! https://codereview.chromium.org/564373004/diff/20001/dart/site/try/poi/poi.dart File dart/site/try/poi/poi.dart (right): https://codereview.chromium.org/564373004/diff/20001/dart/site/try/poi/poi.dart#newcode385 dart/site/try/poi/poi.dart:385: // newCompiler.enqueuerFilter = filter; On 2014/09/16 ...
6 years, 3 months ago (2014-09-16 11:04:56 UTC) #5
ahe
Uploaded new patch set.
6 years, 3 months ago (2014-09-16 11:09:04 UTC) #6
ahe
6 years, 3 months ago (2014-09-16 11:15:17 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as 40311 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698