Cleanup printing of propagated types to make it easier to read.

Cleanup printing of propagated types to make it easier to read.

BUG=
R=fschneider@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40148

[Vyacheslav Egorov (Google), 2014-09-11 13:26:38]

vegorov@google.com changed reviewers:
+ fschneider@google.com

[Vyacheslav Egorov (Google), 2014-09-11 13:26:38]

PTAL

T{not-null, _Smi@asdasda, int} becomes T{_Smi}
T{null, _Double@, _Double} becomes T{_Double?}
T{not-null, dynamic, ...} becomes T{!null}
T{null, dynamic, ...} is not printed

[Florian Schneider, 2014-09-11 13:30:25]

lgtm

https://codereview.chromium.org/563763003/diff/1/runtime/vm/il_printer.cc
File runtime/vm/il_printer.cc (right):

https://codereview.chromium.org/563763003/diff/1/runtime/vm/il_printer.cc#new...
runtime/vm/il_printer.cc:116: if ((cid_ != kIllegalCid) &&
Fits one line?

https://codereview.chromium.org/563763003/diff/1/runtime/vm/il_printer.cc#new...
runtime/vm/il_printer.cc:121: } else if (type_ != NULL &&
Maybe move indentation until (

https://codereview.chromium.org/563763003/diff/1/runtime/vm/il_printer.cc#new...
runtime/vm/il_printer.cc:231: ((type_->ToNullableCid() != kDynamicCid) ||
Fits one line?

[Vyacheslav Egorov (Google), 2014-09-11 13:36:42]

https://codereview.chromium.org/563763003/diff/1/runtime/vm/il_printer.cc
File runtime/vm/il_printer.cc (right):

https://codereview.chromium.org/563763003/diff/1/runtime/vm/il_printer.cc#new...
runtime/vm/il_printer.cc:116: if ((cid_ != kIllegalCid) &&
On 2014/09/11 13:30:24, Florian Schneider wrote:
> Fits one line?

Done.

https://codereview.chromium.org/563763003/diff/1/runtime/vm/il_printer.cc#new...
runtime/vm/il_printer.cc:121: } else if (type_ != NULL &&
On 2014/09/11 13:30:24, Florian Schneider wrote:
> Maybe move indentation until (

Done.

https://codereview.chromium.org/563763003/diff/1/runtime/vm/il_printer.cc#new...
runtime/vm/il_printer.cc:231: ((type_->ToNullableCid() != kDynamicCid) ||
On 2014/09/11 13:30:24, Florian Schneider wrote:
> Fits one line?

Done.

[Vyacheslav Egorov (Google), 2014-09-11 13:37:05]

Committed patchset #1 (id:1) manually as 40148 (presubmit successful).