Issue 19799. Merge getter/setter pairs into fields when create missing overrides.

Issue 19799. Merge getter/setter pairs into fields when create missing overrides.

R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=19799

Committed: https://code.google.com/p/dart/source/detail?r=40220

[Paul Berry, 2014-09-12 20:29:01]

lgtm

https://codereview.chromium.org/563333002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/correction/fix_internal.dart (right):

https://codereview.chromium.org/563333002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/correction/fix_internal.dart:608: if
(a.kind == ElementKind.GETTER) {
In practice this will work, but strictly speaking it's not a total ordering (as
required by sort()).  Can we do something like this instead?

int names = compareStrings(a.displayName, b.displayName);
if (names != 0) {
  return names;
}
return a.kind.ordinal - b.kind.ordinal;

https://codereview.chromium.org/563333002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/correction/fix_internal.dart:630: // remove
this and the next elements, adjust iterator
Should we also decrement numElements, so that the fix message will be consistent
with the number of elements added?

[scheglov, 2014-09-12 21:29:15]

Committed patchset #2 (id:20001) manually as 40220 (presubmit successful).

[scheglov, 2014-09-12 21:29:29]

https://codereview.chromium.org/563333002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/correction/fix_internal.dart (right):

https://codereview.chromium.org/563333002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/correction/fix_internal.dart:608: if
(a.kind == ElementKind.GETTER) {
On 2014/09/12 20:29:01, Paul Berry wrote:
> In practice this will work, but strictly speaking it's not a total ordering
(as
> required by sort()).  Can we do something like this instead?
> 
> int names = compareStrings(a.displayName, b.displayName);
> if (names != 0) {
>   return names;
> }
> return a.kind.ordinal - b.kind.ordinal;

We could, but I anticipate that we will want to move away from using Java enums,
so "ordinal" may go away too. So, I'd not like to introduce something what will
force us to support it.

https://codereview.chromium.org/563333002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/correction/fix_internal.dart:630: // remove
this and the next elements, adjust iterator
On 2014/09/12 20:29:01, Paul Berry wrote:
> Should we also decrement numElements, so that the fix message will be
consistent
> with the number of elements added?

I considered this, and decided that I'm not sure.
Formally we implement 2 members for each field.
But I think you are right, we should say how many "physical" members will be
added.