Recompute librariesByName after loading a deferred library.

Recompute librariesByName after loading a deferred library.

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40204

[sigurdm, 2014-09-11 07:55:43]

sigurdm@google.com changed reviewers:
+ floitsch@google.com

[sigurdm, 2014-09-11 07:57:16]

Patchset #1 (id:1) has been deleted

[floitsch, 2014-09-11 09:01:28]

LGTM.

https://codereview.chromium.org/562853002/diff/20001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/js_lib/js_helper.dart (right):

https://codereview.chromium.org/562853002/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:3260: typedef void
voidFunction();
typedefs are capitalized.
I think "XCallback" is what we usually use. So here "DeferredLoadCallback"

https://codereview.chromium.org/562853002/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:3263: voidFunction
librariesUpdatedHook;
deferredLoadHook ?

https://codereview.chromium.org/562853002/diff/20001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/js_lib/js_mirrors.dart (right):

https://codereview.chromium.org/562853002/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/js_lib/js_mirrors.dart:106: librariesUpdatedHook = ()
=> _librariesByName = computeLibrariesByName();
() => _librariesByName = null.

When there are several files that are loaded we don't want to compute the
libraries one by one.
You will want to make the deferredLoad registration depending (on a local
boolean flag?)

[sigurdm, 2014-09-11 12:06:44]

PTAL

https://codereview.chromium.org/562853002/diff/20001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/js_lib/js_helper.dart (right):

https://codereview.chromium.org/562853002/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:3260: typedef void
voidFunction();
On 2014/09/11 09:01:27, floitsch wrote:
> typedefs are capitalized.
> I think "XCallback" is what we usually use. So here "DeferredLoadCallback"

Done.

https://codereview.chromium.org/562853002/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:3263: voidFunction
librariesUpdatedHook;
On 2014/09/11 09:01:27, floitsch wrote:
> deferredLoadHook ?

Done.

https://codereview.chromium.org/562853002/diff/20001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/js_lib/js_mirrors.dart (right):

https://codereview.chromium.org/562853002/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/js_lib/js_mirrors.dart:106: librariesUpdatedHook = ()
=> _librariesByName = computeLibrariesByName();
On 2014/09/11 09:01:27, floitsch wrote:
> () => _librariesByName = null.
> 
> When there are several files that are loaded we don't want to compute the
> libraries one by one.
> You will want to make the deferredLoad registration depending (on a local
> boolean flag?)

Done.

[floitsch, 2014-09-11 13:25:29]

LGTM.

https://codereview.chromium.org/562853002/diff/40001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/js_lib/js_mirrors.dart (right):

https://codereview.chromium.org/562853002/diff/40001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/js_lib/js_mirrors.dart:103: static bool
_hasSetDeferredLoadHook = false;
_hasInstalledDeferredLoadHook.

Add comment.

[sigurdm, 2014-09-11 13:54:41]

https://codereview.chromium.org/562853002/diff/40001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/js_lib/js_mirrors.dart (right):

https://codereview.chromium.org/562853002/diff/40001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/js_lib/js_mirrors.dart:103: static bool
_hasSetDeferredLoadHook = false;
On 2014/09/11 13:25:29, floitsch wrote:
> _hasInstalledDeferredLoadHook.
> 
> Add comment.

Done.

[sigurdm, 2014-09-12 09:35:25]

Committed patchset #3 (id:60001) manually as 40204 (presubmit successful).