ddbg_service changes.

ddbg_service changes.

Make a CommandList class and move command matching and completion
logic into it.  Rework command completion to begin to allow for
recursive completion of subcommands.

BUG=
R=johnmccutchan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40564

[turnidge, 2014-09-17 16:06:24]

turnidge@google.com changed reviewers:
+ johnmccutchan@google.com

[turnidge, 2014-09-17 16:06:25]

https://codereview.chromium.org/562273005/diff/1/tools/ddbg_service/lib/comma...
File tools/ddbg_service/lib/commando.dart (left):

https://codereview.chromium.org/562273005/diff/1/tools/ddbg_service/lib/comma...
tools/ddbg_service/lib/commando.dart:352: completion = completion + ' ';
Now all completions come back with a space at the end.  The shared prefix
finding only leaves the space on when all completions agree, so this isn't
necessary.

https://codereview.chromium.org/562273005/diff/1/tools/ddbg_service/lib/comma...
File tools/ddbg_service/lib/commando.dart (right):

https://codereview.chromium.org/562273005/diff/1/tools/ddbg_service/lib/comma...
tools/ddbg_service/lib/commando.dart:336: return line != ' ' && line != '';
My old command parsing introduced empty command parts between each and every
space.  That was a bug.

https://codereview.chromium.org/562273005/diff/1/tools/ddbg_service/lib/comma...
tools/ddbg_service/lib/commando.dart:375: newLine..addAll(completionRunes)
Before I used to preserve all of the user's extra spacing by using their prefix
precisely -- completion would only happen at the tab point.  Now I complete
everywhere on the line up to the tab point and I canonicalize the spacing.  This
makes my life easier.

https://codereview.chromium.org/562273005/diff/1/tools/ddbg_service/lib/debug...
File tools/ddbg_service/lib/debugger.dart (right):

https://codereview.chromium.org/562273005/diff/1/tools/ddbg_service/lib/debug...
tools/ddbg_service/lib/debugger.dart:105: _commands.register(new QuitCommand());
CommandList is now an object and owned by the Debugger.

https://codereview.chromium.org/562273005/diff/1/tools/ddbg_service/lib/debug...
tools/ddbg_service/lib/debugger.dart:177: return ["$name ${commandParts.join('
')}"];
Commands can now implement command-specific completers.

[Cutch, 2014-09-17 20:07:26]

lgtm

https://codereview.chromium.org/562273005/diff/1/tools/ddbg_service/lib/comma...
File tools/ddbg_service/lib/commando.dart (right):

https://codereview.chromium.org/562273005/diff/1/tools/ddbg_service/lib/comma...
tools/ddbg_service/lib/commando.dart:363: completionList.sort((a,b) =>
a.compareTo(b));
You can just call sort(), it will default to compareTo.

https://codereview.chromium.org/562273005/diff/1/tools/ddbg_service/lib/debug...
File tools/ddbg_service/lib/debugger.dart (right):

https://codereview.chromium.org/562273005/diff/1/tools/ddbg_service/lib/debug...
tools/ddbg_service/lib/debugger.dart:177: return ["$name ${commandParts.join('
')}"];
On 2014/09/17 16:06:24, turnidge wrote:
> Commands can now implement command-specific completers.

Nice!

[turnidge, 2014-09-22 20:10:13]

Committed patchset #2 (id:20001) manually as 40564 (presubmit successful).