Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 562123002: Support parameter access in analyzer2dart. (Closed)

Created:
6 years, 3 months ago by Johnni Winther
Modified:
6 years, 3 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org, Paul Berry, Brian Wilkerson
Visibility:
Public.

Description

Support parameter access in analyzer2dart. BUG= R=sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=40142

Patch Set 1 #

Total comments: 2

Messages

Total messages: 5 (1 generated)
Johnni Winther
6 years, 3 months ago (2014-09-11 10:42:38 UTC) #2
sigurdm
lgtm https://codereview.chromium.org/562123002/diff/1/pkg/analyzer2dart/lib/src/cps_generator.dart File pkg/analyzer2dart/lib/src/cps_generator.dart (right): https://codereview.chromium.org/562123002/diff/1/pkg/analyzer2dart/lib/src/cps_generator.dart#newcode43 pkg/analyzer2dart/lib/src/cps_generator.dart:43: /* Why is this commented out?
6 years, 3 months ago (2014-09-11 11:13:13 UTC) #3
Johnni Winther
Committed patchset #1 (id:1) manually as 40142 (presubmit successful).
6 years, 3 months ago (2014-09-11 11:31:30 UTC) #4
Johnni Winther
6 years, 3 months ago (2014-09-11 11:31:40 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/562123002/diff/1/pkg/analyzer2dart/lib/src/cp...
File pkg/analyzer2dart/lib/src/cps_generator.dart (right):

https://codereview.chromium.org/562123002/diff/1/pkg/analyzer2dart/lib/src/cp...
pkg/analyzer2dart/lib/src/cps_generator.dart:43: /*
On 2014/09/11 11:13:13, sigurdm wrote:
> Why is this commented out?

I thought I needed to process the function expression but had to skip it
instead. Removed.

Powered by Google App Engine
This is Rietveld 408576698