Find pub status file in right directory.

Find pub status file in right directory.

R=nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40123

[Bob Nystrom, 2014-09-10 19:51:28]

rnystrom@google.com changed reviewers:
+ nweiz@google.com

[Bob Nystrom, 2014-09-10 19:51:29]

This seemed cleaner to me than having the status file in two places. The pub/
directory should be the source of truth.

[nweiz, 2014-09-10 20:06:44]

On 2014/09/10 19:51:29, Bob Nystrom wrote:
> This seemed cleaner to me than having the status file in two places. The pub/
> directory should be the source of truth.

Shouldn't this modify the async compiler to avoid copying in pub.status again in
the future?

[Bob Nystrom, 2014-09-10 20:09:34]

On 2014/09/10 20:06:44, nweiz wrote:
> On 2014/09/10 19:51:29, Bob Nystrom wrote:
> > This seemed cleaner to me than having the status file in two places. The
pub/
> > directory should be the source of truth.
> 
> Shouldn't this modify the async compiler to avoid copying in pub.status again
in
> the future?

It doesn't. Rico manually copied it over since (before this change) the one in
pub/ was being ignored.

[nweiz, 2014-09-10 21:10:15]

lgtm

[Bob Nystrom, 2014-09-10 22:38:34]

Committed patchset #1 (id:1) manually as 40123 (presubmit successful).

[ricow1, 2014-09-11 09:10:45]

ricow@google.com changed reviewers:
+ ricow@google.com

[ricow1, 2014-09-11 09:10:46]

First off:
I find it odd that the status file is not next to the tests we are running. To
make everything clear, should we, until we don't need this anymore:
Revert all of these hacks and simply load pub_generated as the testsuite, with
that name (pub_generated)?

Secondly, you forgot to copy the suppressions added only in the new status file

[nweiz, 2014-09-11 19:21:50]

On 2014/09/11 09:10:46, ricow1 wrote:
> First off:
> I find it odd that the status file is not next to the tests we are running. To
> make everything clear, should we, until we don't need this anymore:
> Revert all of these hacks and simply load pub_generated as the testsuite, with
> that name (pub_generated)?
> 
> Secondly, you forgot to copy the suppressions added only in the new status
file

I don't think the canonical status file should be in a directory marked as
"generated".