Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 56183003: Refactor scripts, so we have a single entrypoint, dartdoc.py, to generate docs. (Closed)

Created:
7 years, 1 month ago by Emily Fortuna
Modified:
7 years, 1 month ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Refactor scripts, so we have a single entrypoint, dartdoc.py, to generate docs. Also, generate documentation incrementally as a fallback so that some docs are generated rather than an all-or-nothing approach. Also, set a "blacklist" instead of a "whitelist" for annotations. BUG= R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=29780

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -279 lines) Patch
M pkg/docgen/README.md View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/docgen/bin/dartdoc.py View 2 chunks +130 lines, -44 lines 1 comment Download
D pkg/docgen/bin/generate_all_docs.sh View 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/docgen/bin/upload_docgen.py View 4 chunks +20 lines, -20 lines 0 comments Download
M pkg/docgen/lib/docgen.dart View 44 chunks +118 lines, -209 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Emily Fortuna
https://codereview.chromium.org/56183003/diff/70001/pkg/docgen/bin/dartdoc.py File pkg/docgen/bin/dartdoc.py (right): https://codereview.chromium.org/56183003/diff/70001/pkg/docgen/bin/dartdoc.py#newcode10 pkg/docgen/bin/dartdoc.py:10: import optparse argparse was introduced in Python 2.7, and ...
7 years, 1 month ago (2013-11-01 22:34:46 UTC) #1
Alan Knight
Awesome! LGTM
7 years, 1 month ago (2013-11-01 23:10:42 UTC) #2
Emily Fortuna
7 years, 1 month ago (2013-11-01 23:18:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r29780 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698