Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 56153005: Remove SendPortSync and ReceivePortSync. (Closed)

Created:
7 years, 1 month ago by floitsch
Modified:
7 years, 1 month ago
Reviewers:
vsm, justinfagnani
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove SendPortSync and ReceivePortSync. R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=29778

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove third_party/pkg/js and dom/Serialization.dart #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6085 lines) Patch
M sdk/lib/_internal/lib/isolate_helper.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 4 chunks +0 lines, -446 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 6 chunks +3 lines, -456 lines 0 comments Download
M sdk/lib/isolate/isolate.dart View 1 chunk +0 lines, -29 lines 0 comments Download
D tests/html/js_interop_4_test.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D tests/isolate/browser/ports_compilation_browser_test.dart View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/pkg/js/.gitignore View 1 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/pkg/js/AUTHORS View 1 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/pkg/js/LICENSE View 1 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/pkg/js/PATENTS View 1 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/pkg/js/README.md View 1 1 chunk +0 lines, -77 lines 0 comments Download
D third_party/pkg/js/build.dart View 1 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/pkg/js/codereview.settings View 1 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/pkg/js/example/google-chart/bubblechart.dart View 1 1 chunk +0 lines, -53 lines 0 comments Download
D third_party/pkg/js/example/google-chart/bubblechart.html View 1 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/pkg/js/example/google-maps/directions.css View 1 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/pkg/js/example/google-maps/directions.dart View 1 1 chunk +0 lines, -76 lines 0 comments Download
D third_party/pkg/js/example/google-maps/directions.html View 1 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/pkg/js/example/google-maps/marker_simple.dart View 1 1 chunk +0 lines, -104 lines 0 comments Download
D third_party/pkg/js/example/google-maps/marker_simple.html View 1 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/pkg/js/example/twitter/twitter.dart View 1 1 chunk +0 lines, -52 lines 0 comments Download
D third_party/pkg/js/example/twitter/twitter.html View 1 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/pkg/js/gh-pages-template/dart_32_32.gif View 1 Binary file 0 comments Download
D third_party/pkg/js/gh-pages-template/example/dart_32_32.gif View 1 Binary file 0 comments Download
D third_party/pkg/js/gh-pages-template/example/index.html View 1 1 chunk +0 lines, -101 lines 0 comments Download
D third_party/pkg/js/gh-pages-template/index.html View 1 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/pkg/js/lib/dart_interop.js View 1 1 chunk +0 lines, -576 lines 0 comments Download
D third_party/pkg/js/lib/js.dart View 1 1 chunk +0 lines, -1398 lines 0 comments Download
D third_party/pkg/js/lib/js_wrapping.dart View 1 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/pkg/js/lib/src/wrapping/js/array_to_list_adapter.dart View 1 1 chunk +0 lines, -556 lines 0 comments Download
D third_party/pkg/js/lib/src/wrapping/js/date_to_datetime_adapter.dart View 1 1 chunk +0 lines, -56 lines 0 comments Download
D third_party/pkg/js/lib/src/wrapping/js/object_to_map_adapter.dart View 1 1 chunk +0 lines, -55 lines 0 comments Download
D third_party/pkg/js/lib/src/wrapping/magic_proxy.dart View 1 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/pkg/js/lib/src/wrapping/translator.dart View 1 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/pkg/js/lib/src/wrapping/typed_proxy.dart View 1 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/pkg/js/lib/src/wrapping/util.dart View 1 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/pkg/js/pubspec.yaml View 1 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/pkg/js/test/js/browser_tests.dart View 1 1 chunk +0 lines, -522 lines 0 comments Download
D third_party/pkg/js/test/js/browser_tests.html View 1 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/pkg/js/test/js/browser_tests_bootstrap.js View 1 1 chunk +0 lines, -99 lines 0 comments Download
D third_party/pkg/js/test/js_wrapping/browser_tests.dart View 1 1 chunk +0 lines, -400 lines 0 comments Download
D third_party/pkg/js/test/js_wrapping/browser_tests.html View 1 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/pkg/js/tools/create_bootstrap.dart View 1 1 chunk +0 lines, -55 lines 0 comments Download
D third_party/pkg/js/update-ghpages.dart View 1 1 chunk +0 lines, -14 lines 0 comments Download
D tools/dom/src/Isolates.dart View 1 chunk +0 lines, -222 lines 0 comments Download
M tools/dom/src/Serialization.dart View 1 1 chunk +0 lines, -180 lines 0 comments Download
M tools/dom/src/native_DOMImplementation.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 2 chunks +0 lines, -15 lines 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 1 2 chunks +0 lines, -21 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Window.darttemplate View 1 chunk +0 lines, -33 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
floitsch
@Vijay: I haven't patched it into Dartium, but I don't see any reasons why it ...
7 years, 1 month ago (2013-11-01 22:43:06 UTC) #1
justinfagnani
On 2013/11/01 22:43:06, floitsch wrote: > @Vijay: I haven't patched it into Dartium, but I ...
7 years, 1 month ago (2013-11-01 22:44:03 UTC) #2
vsm
lgtm https://codereview.chromium.org/56153005/diff/1/tools/dom/templates/html/dart2js/html_dart2js.darttemplate File tools/dom/templates/html/dart2js/html_dart2js.darttemplate (right): https://codereview.chromium.org/56153005/diff/1/tools/dom/templates/html/dart2js/html_dart2js.darttemplate#newcode81 tools/dom/templates/html/dart2js/html_dart2js.darttemplate:81: part '$AUXILIARY_DIR/Serialization.dart'; I suspect we can get rid ...
7 years, 1 month ago (2013-11-01 22:46:49 UTC) #3
justinfagnani
lgtm On 2013/11/01 22:44:03, justinfagnani wrote: > On 2013/11/01 22:43:06, floitsch wrote: > > @Vijay: ...
7 years, 1 month ago (2013-11-01 22:49:01 UTC) #4
floitsch
https://codereview.chromium.org/56153005/diff/1/tools/dom/templates/html/dart2js/html_dart2js.darttemplate File tools/dom/templates/html/dart2js/html_dart2js.darttemplate (right): https://codereview.chromium.org/56153005/diff/1/tools/dom/templates/html/dart2js/html_dart2js.darttemplate#newcode81 tools/dom/templates/html/dart2js/html_dart2js.darttemplate:81: part '$AUXILIARY_DIR/Serialization.dart'; On 2013/11/01 22:46:49, vsm wrote: > I ...
7 years, 1 month ago (2013-11-01 22:52:32 UTC) #5
floitsch
7 years, 1 month ago (2013-11-01 23:13:52 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 manually as r29778 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698