Issue 56123012: Propagate stack trace when using Future.wait.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 56123012: Propagate stack trace when using Future.wait. (Closed)

Created:
7 years, 1 month ago by floitsch

Modified:
7 years, 1 month ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org, Lasse Reichstein Nielsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Propagate stack trace when using Future.wait. BUG= http://dartbug.com/14755 R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=29923

Patch Set 2 : Fix test and actually run it. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -5 lines)			Patch
	M	sdk/lib/async/future.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	tests/lib/async/futures_test.dart	View	1	3 chunks	+50 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

LGTM https://codereview.chromium.org/56123012/diff/1/tests/lib/async/futures_test.dart File tests/lib/async/futures_test.dart (right): https://codereview.chromium.org/56123012/diff/1/tests/lib/async/futures_test.dart#newcode101 tests/lib/async/futures_test.dart:101: Expect.isNull(stackTrace); isNotNull?

7 years, 1 month ago (2013-11-05 10:21:21 UTC) #2

floitsch

Turns out I wasn't invoking the tests from main (that's why I didn't catch the ...

7 years, 1 month ago (2013-11-05 18:42:12 UTC) #3

floitsch

7 years, 1 month ago (2013-11-05 18:42:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r29923 (presubmit successful).

Expand Messages | Collapse Messages

Issue 56123012: Propagate stack trace when using Future.wait. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix test and actually run it. #

Messages