Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 560643002: Allow trailing / in directory paths (Closed)

Created:
6 years, 3 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 3 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Allow trailing / in directory paths I run into errors as soon as I use tab completion and include a trailing slash in the suite_dir, this help a bit. R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=40093

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools/testing/dart/legacy_path.dart View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Siggi Cherem (dart-lang)
6 years, 3 months ago (2014-09-09 23:18:10 UTC) #3
ricow1
lgtm
6 years, 3 months ago (2014-09-10 05:51:23 UTC) #4
Siggi Cherem (dart-lang)
6 years, 3 months ago (2014-09-10 15:38:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as 40093 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698