Use pub list-package-dirs in analyzer command line

Move package_map_provider.dart from the server to the analyzer package to be used by the command line analyzer.

R=brianwilkerson@google.com, paulberry@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40051

[jwren, 2014-09-09 20:15:45]

jwren@google.com changed reviewers:
+ brianwilkerson@google.com, paulberry@google.com, scheglov@google.com

[jwren, 2014-09-09 20:15:45]

This CL moves the package_map_provider.dart from the server to the analyzer
package to the analyzer package

[Paul Berry, 2014-09-09 20:20:27]

lgtm

https://codereview.chromium.org/560553002/diff/20001/pkg/analyzer/lib/src/ana...
File pkg/analyzer/lib/src/analyzer_impl.dart (right):

https://codereview.chromium.org/560553002/diff/20001/pkg/analyzer/lib/src/ana...
pkg/analyzer/lib/src/analyzer_impl.dart:250: "The flag package-root is
deprecated, by not including it on the command line a call will be made to pub
to compute the package information.");
This error message is confusing to me.  The phrase "by not including it on the
command line" seems to heavily imply that the user *didn't* include it on the
command line, but we only display the message if they did.

How about something like this instead?

"The flag package-root is deprecated.  Remove to use package information
computed by pub."

[Brian Wilkerson, 2014-09-09 20:30:43]

LGTM

https://codereview.chromium.org/560553002/diff/20001/pkg/analyzer/lib/src/ana...
File pkg/analyzer/lib/src/analyzer_impl.dart (right):

https://codereview.chromium.org/560553002/diff/20001/pkg/analyzer/lib/src/ana...
pkg/analyzer/lib/src/analyzer_impl.dart:249: stdout.write(
While it's nice to let users known about the change, there's a good chance that
printing this message will break some automated uses of the analyzer that have
expectations concerning the format of the output (especially if --machine was
specified. It might be better to move this message into the help message.

[jwren, 2014-09-09 20:36:17]

https://codereview.chromium.org/560553002/diff/20001/pkg/analyzer/lib/src/ana...
File pkg/analyzer/lib/src/analyzer_impl.dart (right):

https://codereview.chromium.org/560553002/diff/20001/pkg/analyzer/lib/src/ana...
pkg/analyzer/lib/src/analyzer_impl.dart:249: stdout.write(
On 2014/09/09 20:30:43, Brian Wilkerson wrote:
> While it's nice to let users known about the change, there's a good chance
that
> printing this message will break some automated uses of the analyzer that have
> expectations concerning the format of the output (especially if --machine was
> specified. It might be better to move this message into the help message.

Done.

https://codereview.chromium.org/560553002/diff/20001/pkg/analyzer/lib/src/ana...
pkg/analyzer/lib/src/analyzer_impl.dart:250: "The flag package-root is
deprecated, by not including it on the command line a call will be made to pub
to compute the package information.");
On 2014/09/09 20:20:27, Paul Berry wrote:
> This error message is confusing to me.  The phrase "by not including it on the
> command line" seems to heavily imply that the user *didn't* include it on the
> command line, but we only display the message if they did.
> 
> How about something like this instead?
> 
> "The flag package-root is deprecated.  Remove to use package information
> computed by pub."

Done.

[jwren, 2014-09-09 20:36:45]

Committed patchset #4 (id:60001) manually as 40051 (presubmit successful).

[scheglov, 2014-09-09 21:00:45]

This breaks the analysis_server package, because "analyzer" 0.23.0-dev.0 does
not contain package_map_provider.dart.
We need to publish analyzer and update analysis_server/pubspec.yaml.