Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 560323003: Add discovery service to stable APIs (Closed)

Created:
6 years, 3 months ago by kustermann
Modified:
6 years, 3 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/googleapis.git@master
Visibility:
Public.

Description

Add discovery service to stable APIs - Uses new version of generator (shorter descrpition in READMEs) - Adds discovery service - Bumps versions to v0.1.1 R=sgjesse@google.com Committed: https://github.com/dart-lang/gcloud/commit/c72d8697fd3d5ab1e20d0dc5e749c18e0162468f

Patch Set 1 #

Patch Set 2 : Added CHANGELOG.md #

Patch Set 3 : New generator hash in pubspec.yaml, test files renamed ot have _test.dart postfix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3208 lines, -151420 lines) Patch
M config.yaml View 1 4 chunks +5 lines, -3 lines 0 comments Download
A discovery/googleapis/discovery__v1.json View 1 chunk +674 lines, -0 lines 0 comments Download
A generated/googleapis/CHANGELOG.md View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M generated/googleapis/README.md View 1 chunk +6 lines, -0 lines 0 comments Download
A generated/googleapis/lib/discovery/v1.dart View 1 chunk +1424 lines, -0 lines 0 comments Download
M generated/googleapis/lib/src/common_internal.dart View 1 chunk +1 line, -1 line 0 comments Download
M generated/googleapis/pubspec.yaml View 1 chunk +2 lines, -54 lines 0 comments Download
D generated/googleapis/test/adexchangebuyer/v1_3.dart View 1 2 1 chunk +0 lines, -2264 lines 0 comments Download
A + generated/googleapis/test/adexchangebuyer/v1_3_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/adexchangeseller/v1_1.dart View 1 2 1 chunk +0 lines, -1944 lines 0 comments Download
A + generated/googleapis/test/adexchangeseller/v1_1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/admin/directory_v1.dart View 1 2 1 chunk +0 lines, -5173 lines 0 comments Download
A + generated/googleapis/test/admin/directory_v1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/admin/email_migration_v2.dart View 1 2 1 chunk +0 lines, -136 lines 0 comments Download
A + generated/googleapis/test/admin/email_migration_v2_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/admin/reports_v1.dart View 1 2 1 chunk +0 lines, -939 lines 0 comments Download
A + generated/googleapis/test/admin/reports_v1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/adsense/v1_4.dart View 1 2 1 chunk +0 lines, -3725 lines 0 comments Download
A + generated/googleapis/test/adsense/v1_4_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/adsensehost/v4_1.dart View 1 2 1 chunk +0 lines, -2517 lines 0 comments Download
A + generated/googleapis/test/adsensehost/v4_1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/analytics/v3.dart View 1 2 1 chunk +0 lines, -9020 lines 0 comments Download
A + generated/googleapis/test/analytics/v3_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/androidpublisher/v2.dart View 1 2 1 chunk +0 lines, -4215 lines 0 comments Download
A + generated/googleapis/test/androidpublisher/v2_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/appsactivity/v1.dart View 1 2 1 chunk +0 lines, -541 lines 0 comments Download
A + generated/googleapis/test/appsactivity/v1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/appstate/v1.dart View 1 2 1 chunk +0 lines, -410 lines 0 comments Download
A + generated/googleapis/test/appstate/v1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/bigquery/v2.dart View 1 2 1 chunk +0 lines, -2978 lines 0 comments Download
A + generated/googleapis/test/bigquery/v2_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/blogger/v3.dart View 1 2 1 chunk +0 lines, -3485 lines 0 comments Download
A + generated/googleapis/test/blogger/v3_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/books/v1.dart View 1 2 1 chunk +0 lines, -5615 lines 0 comments Download
A + generated/googleapis/test/books/v1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/calendar/v3.dart View 1 2 1 chunk +0 lines, -3626 lines 0 comments Download
A + generated/googleapis/test/calendar/v3_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/civicinfo/us_v1.dart View 1 2 1 chunk +0 lines, -1344 lines 0 comments Download
A + generated/googleapis/test/civicinfo/us_v1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/civicinfo/v1.dart View 1 2 1 chunk +0 lines, -1344 lines 0 comments Download
A + generated/googleapis/test/civicinfo/v1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/compute/v1.dart View 1 2 1 chunk +0 lines, -13141 lines 0 comments Download
A + generated/googleapis/test/compute/v1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/content/v2.dart View 1 2 1 chunk +0 lines, -4450 lines 0 comments Download
A + generated/googleapis/test/content/v2_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/coordinate/v1.dart View 1 2 1 chunk +0 lines, -1378 lines 0 comments Download
A + generated/googleapis/test/coordinate/v1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/customsearch/v1.dart View 1 2 1 chunk +0 lines, -806 lines 0 comments Download
A + generated/googleapis/test/customsearch/v1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/dfareporting/v1_3.dart View 1 2 1 chunk +0 lines, -2851 lines 0 comments Download
A + generated/googleapis/test/dfareporting/v1_3_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A generated/googleapis/test/discovery/v1_test.dart View 1 2 1 chunk +1118 lines, -0 lines 0 comments Download
D generated/googleapis/test/doubleclickbidmanager/v1.dart View 1 2 1 chunk +0 lines, -1168 lines 0 comments Download
A + generated/googleapis/test/doubleclickbidmanager/v1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/doubleclicksearch/v2.dart View 1 2 1 chunk +0 lines, -1376 lines 0 comments Download
A + generated/googleapis/test/doubleclicksearch/v2_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/drive/v2.dart View 1 2 1 chunk +0 lines, -5466 lines 0 comments Download
A + generated/googleapis/test/drive/v2_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/freebase/v1.dart View 1 2 1 chunk +0 lines, -488 lines 0 comments Download
A + generated/googleapis/test/freebase/v1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/fusiontables/v1.dart View 1 2 1 chunk +0 lines, -2864 lines 0 comments Download
A + generated/googleapis/test/fusiontables/v1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/games/v1.dart View 1 2 1 chunk +0 lines, -6887 lines 0 comments Download
A + generated/googleapis/test/games/v1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/gamesmanagement/v1management.dart View 1 2 1 chunk +0 lines, -1093 lines 0 comments Download
A + generated/googleapis/test/gamesmanagement/v1management_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/gmail/v1.dart View 1 2 1 chunk +0 lines, -2370 lines 0 comments Download
A + generated/googleapis/test/gmail/v1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/groupsmigration/v1.dart View 1 2 1 chunk +0 lines, -107 lines 0 comments Download
A + generated/googleapis/test/groupsmigration/v1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/groupssettings/v1.dart View 1 2 1 chunk +0 lines, -251 lines 0 comments Download
A + generated/googleapis/test/groupssettings/v1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/identitytoolkit/v3.dart View 1 2 1 chunk +0 lines, -1567 lines 0 comments Download
A + generated/googleapis/test/identitytoolkit/v3_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/licensing/v1.dart View 1 2 1 chunk +0 lines, -568 lines 0 comments Download
A + generated/googleapis/test/licensing/v1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/mapsengine/v1.dart View 1 2 1 chunk +0 lines, -6375 lines 0 comments Download
A + generated/googleapis/test/mapsengine/v1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/mirror/v1.dart View 1 2 1 chunk +0 lines, -2194 lines 0 comments Download
A + generated/googleapis/test/mirror/v1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/oauth2/v2.dart View 1 2 1 chunk +0 lines, -257 lines 0 comments Download
A + generated/googleapis/test/oauth2/v2_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/orkut/v2.dart View 1 2 1 chunk +0 lines, -3766 lines 0 comments Download
A + generated/googleapis/test/orkut/v2_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/pagespeedonline/v1.dart View 1 2 1 chunk +0 lines, -662 lines 0 comments Download
A + generated/googleapis/test/pagespeedonline/v1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/plus/v1.dart View 1 2 1 chunk +0 lines, -2632 lines 0 comments Download
A + generated/googleapis/test/plus/v1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/plusdomains/v1.dart View 1 2 1 chunk +0 lines, -3261 lines 0 comments Download
A + generated/googleapis/test/plusdomains/v1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/prediction/v1_6.dart View 1 2 1 chunk +0 lines, -1376 lines 0 comments Download
A + generated/googleapis/test/prediction/v1_6_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/qpxexpress/v1.dart View 1 2 1 chunk +0 lines, -1214 lines 0 comments Download
A + generated/googleapis/test/qpxexpress/v1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/reseller/v1.dart View 1 2 1 chunk +0 lines, -1097 lines 0 comments Download
A + generated/googleapis/test/reseller/v1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/siteverification/v1.dart View 1 2 1 chunk +0 lines, -565 lines 0 comments Download
A + generated/googleapis/test/siteverification/v1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/storage/v1.dart View 1 2 1 chunk +0 lines, -3198 lines 0 comments Download
A + generated/googleapis/test/storage/v1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/tasks/v1.dart View 1 2 1 chunk +0 lines, -1019 lines 0 comments Download
A + generated/googleapis/test/tasks/v1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/translate/v2.dart View 1 2 1 chunk +0 lines, -453 lines 0 comments Download
A + generated/googleapis/test/translate/v2_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/urlshortener/v1.dart View 1 2 1 chunk +0 lines, -410 lines 0 comments Download
A + generated/googleapis/test/urlshortener/v1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/webfonts/v1.dart View 1 2 1 chunk +0 lines, -195 lines 0 comments Download
A + generated/googleapis/test/webfonts/v1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/youtube/v3.dart View 1 2 1 chunk +0 lines, -7492 lines 0 comments Download
A + generated/googleapis/test/youtube/v3_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis/test/youtubeanalytics/v1.dart View 1 2 1 chunk +0 lines, -566 lines 0 comments Download
A + generated/googleapis/test/youtubeanalytics/v1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A generated/googleapis_beta/CHANGELOG.md View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M generated/googleapis_beta/lib/src/common_internal.dart View 1 chunk +1 line, -1 line 0 comments Download
M generated/googleapis_beta/pubspec.yaml View 1 chunk +2 lines, -13 lines 0 comments Download
D generated/googleapis_beta/test/autoscaler/v1beta2.dart View 1 2 1 chunk +0 lines, -1101 lines 0 comments Download
A + generated/googleapis_beta/test/autoscaler/v1beta2_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis_beta/test/cloudmonitoring/v2beta1.dart View 1 2 1 chunk +0 lines, -858 lines 0 comments Download
A + generated/googleapis_beta/test/cloudmonitoring/v2beta1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis_beta/test/datastore/v1beta2.dart View 1 2 1 chunk +0 lines, -1750 lines 0 comments Download
A + generated/googleapis_beta/test/datastore/v1beta2_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis_beta/test/dns/v1beta1.dart View 1 2 1 chunk +0 lines, -920 lines 0 comments Download
A + generated/googleapis_beta/test/dns/v1beta1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis_beta/test/genomics/v1beta.dart View 1 2 1 chunk +0 lines, -3844 lines 0 comments Download
A + generated/googleapis_beta/test/genomics/v1beta_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis_beta/test/manager/v1beta2.dart View 1 2 1 chunk +0 lines, -1952 lines 0 comments Download
A + generated/googleapis_beta/test/manager/v1beta2_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis_beta/test/pubsub/v1beta1.dart View 1 2 1 chunk +0 lines, -1105 lines 0 comments Download
A + generated/googleapis_beta/test/pubsub/v1beta1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis_beta/test/replicapool/v1beta1.dart View 1 2 1 chunk +0 lines, -1698 lines 0 comments Download
A + generated/googleapis_beta/test/replicapool/v1beta1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis_beta/test/resourceviews/v1beta1.dart View 1 2 1 chunk +0 lines, -1414 lines 0 comments Download
A + generated/googleapis_beta/test/resourceviews/v1beta1_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis_beta/test/sqladmin/v1beta3.dart View 1 2 1 chunk +0 lines, -3131 lines 0 comments Download
A + generated/googleapis_beta/test/sqladmin/v1beta3_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D generated/googleapis_beta/test/taskqueue/v1beta2.dart View 1 2 1 chunk +0 lines, -791 lines 0 comments Download
A + generated/googleapis_beta/test/taskqueue/v1beta2_test.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M pubspec.lock View 1 2 2 chunks +3 lines, -7 lines 0 comments Download
M pubspec.yaml View 1 2 1 chunk +1 line, -1 line 0 comments Download
A resources/googleapis/CHANGELOG.md View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
A resources/googleapis_beta/CHANGELOG.md View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
kustermann
6 years, 3 months ago (2014-09-11 15:34:50 UTC) #2
kustermann
This will enable us to self-host the generator with these APIs.
6 years, 3 months ago (2014-09-11 15:35:01 UTC) #3
Søren Gjesse
lgtm
6 years, 3 months ago (2014-09-12 06:14:45 UTC) #4
Søren Gjesse
Shouldn't we add a CHANGELOG.md file with high level changes for each release? E.g. Version ...
6 years, 3 months ago (2014-09-12 06:41:46 UTC) #5
kustermann
This works with CL https://codereview.chromium.org/563213002/ Once the other CL lands, I'll also update pubspec.yaml to ...
6 years, 3 months ago (2014-09-12 07:20:55 UTC) #6
Søren Gjesse
lgtm
6 years, 3 months ago (2014-09-12 07:27:44 UTC) #7
kustermann
6 years, 3 months ago (2014-09-12 09:45:09 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as c72d869 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698