Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 560293004: Properly handle barback logs after a transformer's been canceled. (Closed)

Created:
6 years, 3 months ago by nweiz
Modified:
6 years, 3 months ago
CC:
reviews_dartlang.org, Bob Nystrom
Visibility:
Public.

Description

Properly handle barback logs after a transformer's been canceled. R=jmesserly@google.com BUG=20180 Committed: https://code.google.com/p/dart/source/detail?r=40185

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M pkg/barback/CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/barback/lib/src/transformer/base_transform.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/barback/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
nweiz
6 years, 3 months ago (2014-09-11 21:02:16 UTC) #1
Jennifer Messerly
lgtm!w
6 years, 3 months ago (2014-09-11 21:39:44 UTC) #2
nweiz
Committed patchset #1 (id:1) manually as 40185 (presubmit successful).
6 years, 3 months ago (2014-09-11 21:51:54 UTC) #3
Bob Nystrom
6 years, 3 months ago (2014-09-12 17:53:55 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698