Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 56023004: Replace Uint32x4/Uint32x4List with Int32x4/Int32x4List (Closed)

Created:
7 years, 1 month ago by Cutch
Modified:
7 years, 1 month ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

This is the final breaking change in dart:typed_data needed for Dart 1.0. We need this change because the ECMAScript SIMD specification only includes Int32x4 and Int32x4List and our types must match. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=29849

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1273 lines, -1528 lines) Patch
M runtime/lib/simd128.cc View 9 chunks +185 lines, -185 lines 0 comments Download
M runtime/lib/typed_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/typed_data.dart View 9 chunks +121 lines, -121 lines 0 comments Download
M runtime/platform/globals.h View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 5 chunks +33 lines, -33 lines 0 comments Download
M runtime/vm/deferred_objects.h View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/deferred_objects.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M runtime/vm/deopt_instructions.h View 2 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/deopt_instructions.cc View 10 chunks +22 lines, -22 lines 0 comments Download
M runtime/vm/flow_graph_allocator.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 37 chunks +89 lines, -89 lines 0 comments Download
M runtime/vm/flow_graph_type_propagator.cc View 1 5 chunks +20 lines, -20 lines 0 comments Download
M runtime/vm/il_printer.cc View 1 5 chunks +15 lines, -15 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 48 chunks +107 lines, -107 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 2 chunks +7 lines, -7 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 33 chunks +57 lines, -57 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 30 chunks +55 lines, -55 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 13 chunks +31 lines, -31 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 33 chunks +54 lines, -54 lines 0 comments Download
M runtime/vm/intrinsifier.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/isolate.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/locations.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.h View 1 5 chunks +21 lines, -21 lines 0 comments Download
M runtime/vm/object.cc View 1 11 chunks +42 lines, -42 lines 0 comments Download
M runtime/vm/object_store.h View 3 chunks +8 lines, -8 lines 0 comments Download
M runtime/vm/object_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/raw_object.h View 6 chunks +14 lines, -14 lines 0 comments Download
M runtime/vm/raw_object.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/snapshot.h View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/symbols.h View 1 5 chunks +8 lines, -8 lines 0 comments Download
M sdk/lib/typed_data/dart2js/typed_data_dart2js.dart View 15 chunks +78 lines, -78 lines 0 comments Download
M sdk/lib/typed_data/typed_data.dart View 7 chunks +46 lines, -46 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 1 1 chunk +9 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 1 chunk +9 lines, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 1 chunk +9 lines, -0 lines 0 comments Download
M tests/lib/typed_data/float32x4_test.dart View 7 chunks +45 lines, -45 lines 0 comments Download
M tests/lib/typed_data/float32x4_unbox_regress_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A tests/lib/typed_data/int32x4_arithmetic_test.dart View 1 chunk +99 lines, -0 lines 0 comments Download
A + tests/lib/typed_data/int32x4_list_test.dart View 8 chunks +13 lines, -13 lines 0 comments Download
A + tests/lib/typed_data/int32x4_shuffle_test.dart View 5 chunks +9 lines, -9 lines 0 comments Download
A + tests/lib/typed_data/int32x4_sign_mask_test.dart View 1 chunk +12 lines, -12 lines 0 comments Download
D tests/lib/typed_data/uint32x4_arithmetic_test.dart View 1 chunk +0 lines, -99 lines 0 comments Download
D tests/lib/typed_data/uint32x4_list_test.dart View 1 chunk +0 lines, -161 lines 0 comments Download
D tests/lib/typed_data/uint32x4_shuffle_test.dart View 1 chunk +0 lines, -59 lines 0 comments Download
D tests/lib/typed_data/uint32x4_sign_mask_test.dart View 1 chunk +0 lines, -62 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Cutch
7 years, 1 month ago (2013-11-02 14:45:50 UTC) #1
srdjan
7 years, 1 month ago (2013-11-04 17:05:29 UTC) #2
srdjan
lgtm
7 years, 1 month ago (2013-11-04 17:05:35 UTC) #3
Cutch
7 years, 1 month ago (2013-11-04 21:57:34 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as r29849 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698