Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 55943002: Remove some unused fields from class SourceLabel. (Closed)

Created:
7 years, 1 month ago by Kevin Millikin (Google)
Modified:
7 years, 1 month ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Remove some unused fields from class SourceLabel. We no longer need assembler labels in the AST. R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=29793

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -13 lines) Patch
M runtime/vm/scopes.h View 4 chunks +5 lines, -10 lines 0 comments Download
M runtime/vm/scopes.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Google)
7 years, 1 month ago (2013-11-01 14:19:59 UTC) #1
Florian Schneider
Lgtm.
7 years, 1 month ago (2013-11-01 15:08:33 UTC) #2
Kevin Millikin (Google)
7 years, 1 month ago (2013-11-04 08:12:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r29793 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698