Issue 559313004: VM: Remove unreachable code from the code generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 559313004: VM: Remove unreachable code from the code generator. (Closed)

Created:
6 years, 3 months ago by Florian Schneider

Modified:
6 years, 3 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

VM: Remove unreachable code from the code generator. In the case of zero checks, the optimizer does not specialize an instance call when visiting (FlowGraphOptimizer::VisitInstanceCall). There is no need to have code for this case in the code generator. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=40434

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -30 lines)			Patch
M	runtime/vm/intermediate_language.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	2 chunks	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Florian Schneider

6 years, 3 months ago (2014-09-18 13:05:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r40434 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages