Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 559203003: Fix wrong conversion from double to bigint in overriden operators of new bigint. (Closed)

Created:
6 years, 3 months ago by regis
Modified:
6 years, 3 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix wrong conversion from double to bigint in overriden operators of new bigint. Fix ambiguous call to pow on Windows. Fix big_integer_vm_test to use numbers large enough to actually be bigint. Re-enable dart2js tests. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=40122

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -47 lines) Patch
M runtime/lib/bigint.dart View 1 2 3 1 chunk +10 lines, -16 lines 0 comments Download
M runtime/lib/double.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/integers.dart View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M tests/corelib/big_integer_vm_test.dart View 7 chunks +32 lines, -26 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
regis
6 years, 3 months ago (2014-09-10 20:24:56 UTC) #2
srdjan
LGTM but could you add a test that, e.g., multiplication of bigint with double returns ...
6 years, 3 months ago (2014-09-10 21:11:48 UTC) #3
regis
On 2014/09/10 21:11:48, srdjan wrote: > LGTM but could you add a test that, e.g., ...
6 years, 3 months ago (2014-09-10 22:19:05 UTC) #4
regis
6 years, 3 months ago (2014-09-10 22:27:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as r40122 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698