Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 55903004: Fixing BeforeUnloadEvent.returnValue (Closed)

Created:
7 years, 1 month ago by blois
Modified:
7 years, 1 month ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixing BeforeUnloadEvent.returnValue This is an update of https://codereview.chromium.org/54913005/ which was failing on the Dartium bots. Original is patch #1, fix is #2 (re-ordering the parts in html_dartium). Issue with the original appears to be that parts have some order-dependency in the VM when executing with --error_on_bad_type, which is used in snapshotting. Opened bug https://code.google.com/p/dart/issues/detail?id=14721 BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=29766

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -81 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +9 lines, -2 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 6 chunks +58 lines, -68 lines 0 comments Download
M tools/dom/dom.json View 1 chunk +5 lines, -2 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 3 chunks +17 lines, -5 lines 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Window.darttemplate View 4 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
blois
7 years, 1 month ago (2013-11-01 19:37:49 UTC) #1
vsm
lgtm https://codereview.chromium.org/55903004/diff/60001/tools/dom/templates/html/dartium/html_dartium.darttemplate File tools/dom/templates/html/dartium/html_dartium.darttemplate (right): https://codereview.chromium.org/55903004/diff/60001/tools/dom/templates/html/dartium/html_dartium.darttemplate#newcode57 tools/dom/templates/html/dartium/html_dartium.darttemplate:57: part '$AUXILIARY_DIR/WrappedEvent.dart'; Can you add a comment pointing ...
7 years, 1 month ago (2013-11-01 19:43:11 UTC) #2
blois
https://codereview.chromium.org/55903004/diff/60001/tools/dom/templates/html/dartium/html_dartium.darttemplate File tools/dom/templates/html/dartium/html_dartium.darttemplate (right): https://codereview.chromium.org/55903004/diff/60001/tools/dom/templates/html/dartium/html_dartium.darttemplate#newcode57 tools/dom/templates/html/dartium/html_dartium.darttemplate:57: part '$AUXILIARY_DIR/WrappedEvent.dart'; On 2013/11/01 19:43:12, vsm wrote: > Can ...
7 years, 1 month ago (2013-11-01 19:50:16 UTC) #3
blois
7 years, 1 month ago (2013-11-01 19:53:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r29766 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698