Issue 558753003: Fix ancient Windows freelist bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 558753003: Fix ancient Windows freelist bug. (Closed)

Created:
6 years, 3 months ago by koda

Modified:
6 years, 3 months ago

Reviewers:
siva, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix ancient Windows freelist bug. Since r9836 (July 2012), we have been searching the freelists in the wrong order on Windows. The recently added bit_set_test.cc uncovered this bug. Also add dedicated unit test case for Utils::Count*Zeros. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=40067

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -4 lines)			Patch
	M	runtime/platform/utils_win.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
	M	runtime/vm/utils_test.cc	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

koda

FYI, the only other place where Utils::CountTrailingZeros is currently used is the arm64 assembler, which ...

6 years, 3 months ago (2014-09-09 22:44:44 UTC) #3

koda

Committed patchset #2 (id:40001) manually as r40067 (presubmit successful).

6 years, 3 months ago (2014-09-09 22:59:08 UTC) #7

Message was sent while issue was closed.

LGTM+1

-Ivan

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages