Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 558633002: Mark [this] as exposed if generative constructor contains function expression. (Closed)

Created:
6 years, 3 months ago by herhut
Modified:
6 years, 3 months ago
Reviewers:
karlklose, floitsch
CC:
reviews_dartlang.org, floitsch
Visibility:
Public.

Description

Mark [this] as exposed if generative constructor contains function expression. BUG= http://dartbug.com/20840 R=floitsch@google.com, karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=40028

Patch Set 1 : #

Patch Set 2 : minor fix to test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M sdk/lib/_internal/compiler/implementation/inferrer/simple_types_inferrer.dart View 1 chunk +5 lines, -0 lines 0 comments Download
A tests/language/regress_20840_test.dart View 1 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
herhut
6 years, 3 months ago (2014-09-09 13:24:20 UTC) #2
floitsch
LGTM.
6 years, 3 months ago (2014-09-09 13:29:43 UTC) #4
herhut
6 years, 3 months ago (2014-09-09 13:43:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as 40028 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698