Issue 55863002: Suppress flake in co19/LibTest/async/Future/catchError_A03_t05 on ie9

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 55863002: Suppress flake in co19/LibTest/async/Future/catchError_A03_t05 on ie9 (Closed)

Created:
7 years, 1 month ago by ricow1

Modified:
7 years, 1 month ago

Reviewers:
floitsch, kustermann

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Suppress flake in co19/LibTest/async/Future/catchError_A03_t05 on ie9 BUG: 14712 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=29784

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	tests/co19/co19-dart2js.status	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

floitsch

LGTM, although it is weird. The test itself looks very deterministic. Note: it would have ...

7 years, 1 month ago (2013-11-01 17:12:41 UTC) #2

floitsch

Updated so it only marks the test as flaky in checked mode. Will commit for ...

7 years, 1 month ago (2013-11-02 00:49:19 UTC) #3

floitsch

Committed patchset #2 manually as r29784 (presubmit successful).

7 years, 1 month ago (2013-11-02 00:49:45 UTC) #4

floitsch

7 years, 1 month ago (2013-11-02 00:50:32 UTC) #5

Message was sent while issue was closed.

It's too late now, but I normally don't put "BUG= " if the CL doesn't solve the
issue.