Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 55853003: add useful docs for logging (Closed)

Created:
7 years, 1 month ago by sethladd
Modified:
7 years, 1 month ago
Reviewers:
kevmoo-old
CC:
reviews_dartlang.org, Kathy Walrath
Visibility:
Public.

Description

add useful docs for logging BUG= R=kevmoo@j832.com Committed: https://code.google.com/p/dart/source/detail?r=29761

Patch Set 1 #

Total comments: 1

Patch Set 2 : simplify #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -4 lines) Patch
M pkg/logging/lib/logging.dart View 1 1 chunk +40 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sethladd
ptal Thanks!
7 years, 1 month ago (2013-11-01 17:42:14 UTC) #1
kevmoo-old
7 years, 1 month ago (2013-11-01 17:49:08 UTC) #2
kevmoo-old
https://codereview.chromium.org/55853003/diff/1/pkg/logging/lib/logging.dart File pkg/logging/lib/logging.dart (right): https://codereview.chromium.org/55853003/diff/1/pkg/logging/lib/logging.dart#newcode23 pkg/logging/lib/logging.dart:23: * StringBuffer sb = new StringBuffer() Maybe use a ...
7 years, 1 month ago (2013-11-01 17:49:19 UTC) #3
sethladd
simplified.
7 years, 1 month ago (2013-11-01 17:54:15 UTC) #4
kevmoo-old
LGTM
7 years, 1 month ago (2013-11-01 18:01:06 UTC) #5
sethladd
7 years, 1 month ago (2013-11-01 18:01:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r29761 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698