Checks snapshot validity using a hash of source file instead of a version string.

Checks snapshot validity using a hash of source file instead of a version string.

R=asiva@google.com, iposva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40009

[zra, 2014-09-08 23:14:10]

zra@google.com changed reviewers:
+ asiva@google.com, iposva@google.com

[zra, 2014-09-08 23:14:10]

Did I miss any files?

[siva, 2014-09-08 23:47:46]

LGTM with one comment.

https://codereview.chromium.org/558503002/diff/1/tools/make_version.py
File tools/make_version.py (right):

https://codereview.chromium.org/558503002/diff/1/tools/make_version.py#newcode33
tools/make_version.py:33: 'symbols.cc',
I think we should also include dart_api_impl.cc it has function
to create snapshot/read snapshot etc. changes to that could potentially
make things incompatible.

dart.cc also has some snapshot related stuff when initializing an
isolate.

[Ivan Posva, 2014-09-09 00:08:03]

LGTM

-Ivan

https://codereview.chromium.org/558503002/diff/1/tools/make_version.py
File tools/make_version.py (right):

https://codereview.chromium.org/558503002/diff/1/tools/make_version.py#newcode43
tools/make_version.py:43: vmhash = hashlib.md5()
Anything better than MD5? Should we even care?

[zra, 2014-09-09 01:43:03]

https://codereview.chromium.org/558503002/diff/1/tools/make_version.py
File tools/make_version.py (right):

https://codereview.chromium.org/558503002/diff/1/tools/make_version.py#newcode33
tools/make_version.py:33: 'symbols.cc',
On 2014/09/08 23:47:45, siva wrote:
> I think we should also include dart_api_impl.cc it has function
> to create snapshot/read snapshot etc. changes to that could potentially
> make things incompatible.
> 
> dart.cc also has some snapshot related stuff when initializing an
> isolate.

Done.

https://codereview.chromium.org/558503002/diff/1/tools/make_version.py#newcode43
tools/make_version.py:43: vmhash = hashlib.md5()
On 2014/09/09 00:08:03, Ivan Posva wrote:
> Anything better than MD5? Should we even care?

Since the hash is not being used for any security purpose, I think we don't
care.

[zra, 2014-09-09 01:43:03]

https://codereview.chromium.org/558503002/diff/1/tools/make_version.py
File tools/make_version.py (right):

https://codereview.chromium.org/558503002/diff/1/tools/make_version.py#newcode33
tools/make_version.py:33: 'symbols.cc',
On 2014/09/08 23:47:45, siva wrote:
> I think we should also include dart_api_impl.cc it has function
> to create snapshot/read snapshot etc. changes to that could potentially
> make things incompatible.
> 
> dart.cc also has some snapshot related stuff when initializing an
> isolate.

Done.

https://codereview.chromium.org/558503002/diff/1/tools/make_version.py#newcode43
tools/make_version.py:43: vmhash = hashlib.md5()
On 2014/09/09 00:08:03, Ivan Posva wrote:
> Anything better than MD5? Should we even care?

Since the hash is not being used for any security purpose, I think we don't
care.

[zra, 2014-09-09 01:44:52]

Committed patchset #2 (id:20001) manually as r40009 (presubmit successful).

[Florian Schneider, 2014-09-09 08:47:01]

On 2014/09/08 23:14:10, zra wrote:
> Did I miss any files?

What about runtime/lib?

[zra, 2014-09-09 19:37:41]

On 2014/09/09 08:47:01, Florian Schneider wrote:
> On 2014/09/08 23:14:10, zra wrote:
> > Did I miss any files?
> 
> What about runtime/lib?

After some discussion here, we're not sure why or which files from runtime/lib
would need to be included. Could you explain? Thanks!