Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 558143002: Add pub status file in the generated version. (Closed)

Created:
6 years, 3 months ago by ricow1
Modified:
6 years, 3 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add pub status file in the generated version. I don't think this is the right solution since I don't understand why we need a checked in version of the compiled sources - but I want a green tree. Committed: https://code.google.com/p/dart/source/detail?r=40086

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
A sdk/lib/_internal/pub_generated/pub.status View 1 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ricow1
6 years, 3 months ago (2014-09-10 12:07:05 UTC) #1
ricow1
6 years, 3 months ago (2014-09-10 12:08:54 UTC) #2
ricow1
On 2014/09/10 12:08:54, ricow1 wrote: tbr
6 years, 3 months ago (2014-09-10 12:09:01 UTC) #3
ricow1
Committed patchset #2 (id:20001) manually as r40086 (presubmit successful).
6 years, 3 months ago (2014-09-10 12:09:11 UTC) #4
Bob Nystrom
6 years, 3 months ago (2014-09-10 15:47:34 UTC) #5
Message was sent while issue was closed.
I thought I had things set up correctly so that it would use the status file in
lib/_internal/pub. I definitely don't think we should maintain two of them, and
I was trying to avoid status files mentioning generated stuff by name if
possible.

Do you know if there's something I need to tweak in test.py to make this work?

Should we just kill the status file in the pub/ directory?

Powered by Google App Engine
This is Rietveld 408576698