Issue 55793002: Fix Dartium status after my change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 55793002: Fix Dartium status after my change. (Closed)

Created:
7 years, 1 month ago by fschneider

Modified:
7 years, 1 month ago

Reviewers:
ricow1, Florian Schneider

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix Dartium status after my change. Isolate.spawn is not yet supported in Dartium. R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=29745

Patch Set 2 : #

Total comments: 2

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tests/language/language.status	View	1	1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ricow1

LGTM https://codereview.chromium.org/55793002/diff/40001/tests/language/language.status File tests/language/language.status (right): https://codereview.chromium.org/55793002/diff/40001/tests/language/language.status#newcode81 tests/language/language.status:81: vm/optimized_guarded_field_isolates_test: Skip # Issue 13921. Just mark it ...

7 years, 1 month ago (2013-11-01 11:55:50 UTC) #2

Florian Schneider

7 years, 1 month ago (2013-11-01 11:58:44 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/55793002/diff/40001/tests/language/language.s...
File tests/language/language.status (right):

https://codereview.chromium.org/55793002/diff/40001/tests/language/language.s...
tests/language/language.status:81: vm/optimized_guarded_field_isolates_test:
Skip # Issue 13921.
On 2013/11/01 11:55:51, ricow1 wrote:
> Just mark it as Fail

Done.

Expand Messages | Collapse Messages

Issue 55793002: Fix Dartium status after my change. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages