dart2js: Support https.

dart2js: Support https.

BUG= http://dartbug.com/20836
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40149

[floitsch, 2014-09-10 16:28:22]

floitsch@google.com changed reviewers:
+ karlklose@google.com

[Bill Hesse, 2014-09-11 08:08:39]

whesse@google.com changed reviewers:
+ whesse@google.com

[Bill Hesse, 2014-09-11 08:08:40]

https://codereview.chromium.org/557383002/diff/1/tests/compiler/dart2js/http_...
File tests/compiler/dart2js/http_test.dart (right):

https://codereview.chromium.org/557383002/diff/1/tests/compiler/dart2js/http_...
tests/compiler/dart2js/http_test.dart:83: String inFilePath =
'$scheme://127.0.0.1:$port/http_launch_main.dart';
The only uses of scheme and port are in the expression
'$scheme://127.0.0.1:$port'.  Maybe just use a server_url variable instead? 
Also, then, pass in server_url rather than use a global?

https://codereview.chromium.org/557383002/diff/1/tests/compiler/dart2js/http_...
tests/compiler/dart2js/http_test.dart:145: return new Future.value()
You could make the tests return their input, and say
return cleanup('$scheme://127.0.0.1:${server.port}')
    .then(testNonHttp)
    .then(testHttpMain)
    .then(testHttpLib)
    .then(testHttpPackage)
...

[karlklose, 2014-09-11 13:30:53]

LGTM.

[floitsch, 2014-09-11 13:37:40]

https://codereview.chromium.org/557383002/diff/1/tests/compiler/dart2js/http_...
File tests/compiler/dart2js/http_test.dart (right):

https://codereview.chromium.org/557383002/diff/1/tests/compiler/dart2js/http_...
tests/compiler/dart2js/http_test.dart:83: String inFilePath =
'$scheme://127.0.0.1:$port/http_launch_main.dart';
On 2014/09/11 08:08:40, Bill Hesse wrote:
> The only uses of scheme and port are in the expression
> '$scheme://127.0.0.1:$port'.  Maybe just use a server_url variable instead? 
> Also, then, pass in server_url rather than use a global?

Done.

https://codereview.chromium.org/557383002/diff/1/tests/compiler/dart2js/http_...
tests/compiler/dart2js/http_test.dart:145: return new Future.value()
On 2014/09/11 08:08:40, Bill Hesse wrote:
> You could make the tests return their input, and say
> return cleanup('$scheme://127.0.0.1:${server.port}')
>     .then(testNonHttp)
>     .then(testHttpMain)
>     .then(testHttpLib)
>     .then(testHttpPackage)
> ...

I don't like to return things that don't make sense.
But pass in serverUrl now.

[floitsch, 2014-09-11 13:38:21]

Committed patchset #2 (id:20001) manually as 40149 (presubmit successful).