Check against the correct type when decoding runtime types.

Check against the correct type when decoding runtime types.

The type [Type] is represented by its constructor function in the runtime type system, and if it used as a type argument, we install a $isType-tag on it for subtype checks.

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40045

[floitsch, 2014-09-09 14:37:27]

LGTM.
But needs a test, and more information (either in the test, or in the
description of this CL).

[karlklose, 2014-09-09 15:07:31]

On 2014/09/09 14:37:27, floitsch wrote:
> LGTM.
> But needs a test, and more information (either in the test, or in the
> description of this CL).

PTAL.

[floitsch, 2014-09-09 15:26:25]

Still LGTM.

https://codereview.chromium.org/556833004/diff/40001/tests/lib/mirrors/type_m...
File tests/lib/mirrors/type_mirror_for_type_test.dart (right):

https://codereview.chromium.org/556833004/diff/40001/tests/lib/mirrors/type_m...
tests/lib/mirrors/type_mirror_for_type_test.dart:30:
print(declarationMirror.returnType);
Expect.equals(Type, declarationMirror.returnType);

[karlklose, 2014-09-09 17:17:26]

https://codereview.chromium.org/556833004/diff/40001/tests/lib/mirrors/type_m...
File tests/lib/mirrors/type_mirror_for_type_test.dart (right):

https://codereview.chromium.org/556833004/diff/40001/tests/lib/mirrors/type_m...
tests/lib/mirrors/type_mirror_for_type_test.dart:30:
print(declarationMirror.returnType);
On 2014/09/09 15:26:25, floitsch wrote:
> Expect.equals(Type, declarationMirror.returnType);

Done.

[karlklose, 2014-09-09 17:29:00]

Committed patchset #4 (id:60001) manually as 40045 (presubmit successful).