Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 556573002: Make SdkLibrary.shortName consistently include 'dart:' (Closed)

Created:
6 years, 3 months ago by Paul Berry
Modified:
6 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Make SdkLibrary.shortName consistently include 'dart:' The documentation of SdkLibrary.shortName claimed that it didn't include the 'dart:' prefix; however the implementation did include it. The implementation of shortName in _MockSdkLibrary class (used only for unit testing) did not include the 'dart:' prefix, causing some unit tests to pass even though the functionality was wrong. This change updates the docs and _MockSdkLibrary to correspond to the implementation (the 'dart:' prefix is included). Additionally it fixes one usage of shortName which was expecting the 'dart:' prefix to be absent; this was preventing quick fixes from working correctly. In addition, the Mock SDK is modified to add a reference from dart:core to dart:async and from dart:async to dart:math (these dependencies exist in the real SDK). This avoids the need for some workarounds in unit tests. BUG=dartbug.com/20850 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=40000

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -27 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/sdk/SdkLibrary.java View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/edit/fixes_test.dart View 1 chunk +19 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/mock_sdk.dart View 5 chunks +10 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 5 chunks +0 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
6 years, 3 months ago (2014-09-08 20:34:16 UTC) #2
scheglov
LGTM
6 years, 3 months ago (2014-09-08 20:46:28 UTC) #3
Paul Berry
6 years, 3 months ago (2014-09-08 21:02:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as 40000 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698