Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1202)

Issue 556403003: cherry pick to fix memory leak (Closed)

Created:
6 years, 3 months ago by jakemac
Modified:
6 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix #

Patch Set 3 : apply patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -24 lines) Patch
M pkg/web_components/CHANGELOG.md View 1 1 chunk +1 line, -0 lines 0 comments Download
M pkg/web_components/lib/build.log View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/web_components/lib/platform.js View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/web_components/lib/platform.concat.js View 1 2 5 chunks +16 lines, -13 lines 0 comments Download
M pkg/web_components/lib/platform.concat.js.map View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jakemac
6 years, 3 months ago (2014-09-10 22:10:09 UTC) #2
Siggi Cherem (dart-lang)
https://codereview.chromium.org/556403003/diff/1/pkg/web_components/lib/platform.concat.js File pkg/web_components/lib/platform.concat.js (left): https://codereview.chromium.org/556403003/diff/1/pkg/web_components/lib/platform.concat.js#oldcode2 pkg/web_components/lib/platform.concat.js:2: * Copyright (c) 2014 The Polymer Project Authors. All ...
6 years, 3 months ago (2014-09-10 22:13:52 UTC) #3
jakemac
https://codereview.chromium.org/556403003/diff/1/pkg/web_components/lib/platform.concat.js File pkg/web_components/lib/platform.concat.js (left): https://codereview.chromium.org/556403003/diff/1/pkg/web_components/lib/platform.concat.js#oldcode2 pkg/web_components/lib/platform.concat.js:2: * Copyright (c) 2014 The Polymer Project Authors. All ...
6 years, 3 months ago (2014-09-10 22:37:43 UTC) #4
Siggi Cherem (dart-lang)
lgtm
6 years, 3 months ago (2014-09-10 22:39:03 UTC) #5
jakemac
6 years, 3 months ago (2014-09-10 22:48:47 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:30001) manually as 40126 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698