Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 556363004: Add an error callback to StackZoneSpecification. (Closed)

Created:
6 years, 3 months ago by nweiz
Modified:
6 years, 3 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add an error callback to StackZoneSpecification. This releases stack_trace 1.0.3. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=40383

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -121 lines) Patch
M pkg/stack_trace/CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/stack_trace/README.md View 1 chunk +0 lines, -9 lines 0 comments Download
M pkg/stack_trace/lib/src/chain.dart View 1 chunk +7 lines, -27 lines 0 comments Download
M pkg/stack_trace/lib/src/stack_zone_specification.dart View 4 chunks +28 lines, -3 lines 0 comments Download
M pkg/stack_trace/pubspec.yaml View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/stack_trace/test/chain_test.dart View 5 chunks +112 lines, -80 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
6 years, 3 months ago (2014-09-17 00:55:51 UTC) #1
Bob Nystrom
LGTM! Are you planning to strip all of the track() calls from pub et. al ...
6 years, 3 months ago (2014-09-17 16:55:00 UTC) #2
nweiz
On 2014/09/17 16:55:00, Bob Nystrom wrote: > LGTM! > > Are you planning to strip ...
6 years, 3 months ago (2014-09-17 18:10:01 UTC) #3
nweiz
6 years, 3 months ago (2014-09-17 18:11:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40383 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698