Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 556353002: Fix bug in range analysis. (Closed)

Created:
6 years, 3 months ago by Florian Schneider
Modified:
6 years, 3 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix bug in range analysis. A definition that is in the same block as a phi can never dominate the phi, since phis are at the very start of a block. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=40102

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M runtime/vm/flow_graph_range_analysis.cc View 2 chunks +9 lines, -2 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
Florian Schneider
6 years, 3 months ago (2014-09-10 18:31:49 UTC) #2
Vyacheslav Egorov (Google)
lgtm https://codereview.chromium.org/556353002/diff/1/runtime/vm/flow_graph_range_analysis.cc File runtime/vm/flow_graph_range_analysis.cc (right): https://codereview.chromium.org/556353002/diff/1/runtime/vm/flow_graph_range_analysis.cc#newcode1828 runtime/vm/flow_graph_range_analysis.cc:1828: return a->Dominates(phi_block) && (a != phi_block); You reoder ...
6 years, 3 months ago (2014-09-10 18:33:41 UTC) #3
Florian Schneider
6 years, 3 months ago (2014-09-10 18:56:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r40102 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698