Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 55543003: Move temp_index from the graph visitors to the graph builder. (Closed)

Created:
7 years, 1 month ago by Kevin Millikin (Google)
Modified:
7 years, 1 month ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Move temp_index from the graph visitors to the graph builder. This is the only bit of state that besides the current instruction that is threaded through the visitors. R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=29801

Patch Set 1 #

Patch Set 2 : Header include cleanup. #

Patch Set 3 : More header include cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -158 lines) Patch
M runtime/vm/flow_graph_builder.h View 1 9 chunks +24 lines, -18 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 2 71 chunks +122 lines, -140 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Kevin Millikin (Google)
I'm not entirely thrilled with this change. The original intent was to keep state only ...
7 years, 1 month ago (2013-11-04 09:29:52 UTC) #1
Kevin Millikin (Google)
7 years, 1 month ago (2013-11-04 09:30:07 UTC) #2
Florian Schneider
LGTM. It does make sense to have the state in one place. #args pushed is ...
7 years, 1 month ago (2013-11-04 10:20:46 UTC) #3
Kevin Millikin (Google)
7 years, 1 month ago (2013-11-04 11:48:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r29801 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698